Skip to content

Remove gin index#86896

Merged
rschu1ze merged 7 commits intoClickHouse:masterfrom
rschu1ze:remove-gin-index
Sep 19, 2025
Merged

Remove gin index#86896
rschu1ze merged 7 commits intoClickHouse:masterfrom
rschu1ze:remove-gin-index

Conversation

@rschu1ze
Copy link
Copy Markdown
Member

@rschu1ze rschu1ze commented Sep 9, 2025 •
edited
Loading

Obsoleted by #86485

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@rschu1ze rschu1ze force-pushed the remove-gin-index branch 3 times, most recently from 3c27a4f to e3051b8 Compare September 12, 2025 10:11
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Sep 12, 2025 •
edited
Loading

Workflow [PR], commit [ca26f00]

Summary: ✅

@clickhouse-gh clickhouse-gh bot added pr-not-for-changelog This PR should not be mentioned in the changelog submodule changed At least one submodule changed in this PR. labels Sep 12, 2025
@rschu1ze rschu1ze mentioned this pull request Sep 17, 2025
Merged
@rschu1ze rschu1ze marked this pull request as ready for review September 17, 2025 22:35
@rschu1ze rschu1ze changed the title *wip* Remove Gin index Remove Gin index Sep 17, 2025
@rschu1ze rschu1ze changed the title Remove Gin index Remove gin index Sep 17, 2025
george-larionov
george-larionov reviewed Sep 18, 2025
View reviewed changes
@rschu1ze
Copy link
Copy Markdown
Member Author

rschu1ze commented Sep 18, 2025

Got weird build errors in the sync PR ... I closed it and merged from master again.

@george-larionov
Copy link
Copy Markdown
Member

george-larionov commented Sep 18, 2025

Here are some more references to Gin (just comments):

@rschu1ze
Copy link
Copy Markdown
Member Author

rschu1ze commented Sep 18, 2025

@george-larionov Done, thanks.

george-larionov
george-larionov approved these changes Sep 18, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@george-larionov george-larionov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rschu1ze
Copy link
Copy Markdown
Member Author

rschu1ze commented Sep 19, 2025

image image

@rschu1ze rschu1ze added this pull request to the merge queue Sep 19, 2025
Merged via the queue into ClickHouse:master with commit d77aadf Sep 19, 2025
123 checks passed
@rschu1ze rschu1ze deleted the remove-gin-index branch September 19, 2025 09:24
@robot-ch-test-poll robot-ch-test-poll added the pr-synced-to-cloud The PR is synced to the cloud repo label Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@george-larionov george-larionov george-larionov approved these changes

Assignees

No one assigned

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo submodule changed At least one submodule changed in this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rschu1ze @george-larionov @robot-ch-test-poll