Skip to content

add cpu and memory overload warnings#86838

Merged
bharatnc merged 5 commits intomasterfrom
ncb/system-warning-cpu-mem
Sep 15, 2025
Merged

add cpu and memory overload warnings#86838
bharatnc merged 5 commits intomasterfrom
ncb/system-warning-cpu-mem

Conversation

@bharatnc
Copy link
Copy Markdown
Contributor

@bharatnc bharatnc commented Sep 8, 2025

Add overload warnings for cpu and memory to system.warnings table.

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Add warnings for cpu and memory to system.warnings table.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@bharatnc bharatnc requested a review from azat September 8, 2025 15:18
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Sep 8, 2025

Workflow [PR], commit [174dd50]

Summary:

job_name test_name status info comment
Stateless tests (amd_binary, old analyzer, s3 storage, DatabaseReplicated, sequential) failure
01079_parallel_alter_detach_table_zookeeper FAIL
Integration tests (amd_tsan, 1/6) failure
test_storage_iceberg_disks/test.py::test_single_iceberg_file[s3-2] FAIL
test_storage_iceberg_disks/test.py::test_cluster_table_function[s3] FAIL
test_storage_iceberg_disks/test.py::test_single_iceberg_file[local-2] FAIL

@clickhouse-gh clickhouse-gh bot added the pr-feature Pull request with new product feature label Sep 8, 2025
@azat
Copy link
Copy Markdown
Member

azat commented Sep 8, 2025

To be honest, I'm not sure that this is the client responsibility to show this, since for instance I use persisten client sessions, while warings are shown only at start so if I am spawning client at the server start more or less, then I will not see this warnings

But it looks cheap and there is already MAX_PENDING_MUTATIONS_EXCEEDS_LIMIT

So I guess it is OK to have them in client as well.

@Algunenano
Copy link
Copy Markdown
Member

To be honest, I'm not sure that this is the client responsibility to show this, since for instance I use persisten client sessions, while warings are shown only at start so if I am spawning client at the server start more or less, then I will not see this warnings

The idea would be that clients, but not necessarily clickhouse-client such a cloud UI, can check system.warnings and show them / alert if needed.

@bharatnc bharatnc force-pushed the ncb/system-warning-cpu-mem branch from 06984bb to c6fee19 Compare September 9, 2025 23:28
@bharatnc bharatnc force-pushed the ncb/system-warning-cpu-mem branch from 88c52bd to 174dd50 Compare September 13, 2025 20:54
@bharatnc
Copy link
Copy Markdown
Contributor Author

Test failures not related:

@bharatnc bharatnc added this pull request to the merge queue Sep 15, 2025
Merged via the queue into master with commit 82e6674 Sep 15, 2025
121 of 123 checks passed
@bharatnc bharatnc deleted the ncb/system-warning-cpu-mem branch September 15, 2025 07:04
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-feature Pull request with new product feature pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants