Skip to content

Disable non sensical binary operations with IPv4/IPv6#86336

Merged
Algunenano merged 2 commits intoClickHouse:masterfrom
Algunenano:ip_logical
Sep 1, 2025
Merged

Disable non sensical binary operations with IPv4/IPv6#86336
Algunenano merged 2 commits intoClickHouse:masterfrom
Algunenano:ip_logical

Conversation

@Algunenano
Copy link
Copy Markdown
Member

@Algunenano Algunenano commented Aug 28, 2025

Changelog category (leave one):

  • Backward Incompatible Change

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Disable non sensical binary operations with IPv4/IPv6: Plus / minus of a IPv4/IPv6 with a non integer type is disabled. Before it would allow operations with floating types and throw logical errors with some other types (such as DateTime).

Tagged as a breaking change just on the off chance case somebody was using this in queries or table/view definitions

Closes #71415

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Aug 28, 2025 •
edited
Loading

Workflow [PR], commit [1dd6be0]

Summary: ❌

job_name test_name status info comment
Stateless tests (amd_ubsan, parallel) failure
Server died FAIL
02497_remote_disk_fat_column SERVER_DIED
01062_pm_all_join_with_block_continuation SERVER_DIED
00962_enumNotExect SERVER_DIED
Exception in test runner FAIL
Killed by signal (in clickhouse-server.log or clickhouse-server.err.log) FAIL
OOM in dmesg FAIL
Integration tests (amd_binary, 3/5) failure
test_asynchronous_metric_jemalloc_profile_active/test.py::test_asynchronous_metric_jemalloc_profile_active FAIL

@clickhouse-gh clickhouse-gh bot added the pr-backward-incompatible Pull request with backwards incompatible changes label Aug 28, 2025
@nickitat nickitat self-assigned this Aug 29, 2025
@Algunenano Algunenano added this pull request to the merge queue Sep 1, 2025
Merged via the queue into ClickHouse:master with commit 04cd20e Sep 1, 2025
231 of 240 checks passed
@Algunenano Algunenano deleted the ip_logical branch September 1, 2025 09:50
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickitat nickitat nickitat approved these changes

Assignees

@nickitat nickitat

Labels

pr-backward-incompatible Pull request with backwards incompatible changes pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Logical Error: Arguments of 'minus' have incorrect data types

3 participants

@Algunenano @nickitat @robot-ch-test-poll2