Skip to content

Fix flaky test 03364_estimate_compression_ratio#86003

Merged
nikitamikhaylov merged 2 commits intomasterfrom
Avogar-patch-8
Aug 22, 2025
Merged

Fix flaky test 03364_estimate_compression_ratio#86003
nikitamikhaylov merged 2 commits intomasterfrom
Avogar-patch-8

Conversation

@Avogar
Copy link
Copy Markdown
Member

@Avogar Avogar commented Aug 21, 2025

Changelog category (leave one):

  • CI Fix or Improvement (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Closes #85999

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Aug 21, 2025 •
edited
Loading

Workflow [PR], commit [6960919]

Summary: ❌

job_name test_name status info comment
Stateless tests (amd_binary, old analyzer, s3 storage, DatabaseReplicated, parallel) failure
03595_alter_drop_column_comment_if_exists FAIL

@clickhouse-gh clickhouse-gh bot added the pr-ci label Aug 21, 2025
@nikitamikhaylov
Copy link
Copy Markdown
Member

nikitamikhaylov commented Aug 21, 2025

Still flaky...

@Avogar Avogar mentioned this pull request Aug 22, 2025
Merged
1 task
@nikitamikhaylov nikitamikhaylov self-assigned this Aug 22, 2025
nikitamikhaylov
nikitamikhaylov reviewed Aug 22, 2025
View reviewed changes
tests/queries/0_stateless/03364_estimate_compression_ratio.sh
tuple_col Tuple(Int64, Tuple(Int64, Int64)),
) ENGINE = MergeTree ORDER BY number_col
SETTINGS min_bytes_for_wide_part = 0"
SETTINGS min_bytes_for_wide_part = 0, ratio_of_defaults_for_sparse_serialization=1, index_granularity=8128"
Copy link
Copy Markdown
Member

@nikitamikhaylov nikitamikhaylov Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not 8192...

Copy link
Copy Markdown
Member Author

@Avogar Avogar Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because my brain said that 8128 is the power of 2 and the default value 🤪

@nikitamikhaylov
Copy link
Copy Markdown
Member

nikitamikhaylov commented Aug 22, 2025

03595_alter_drop_column_comment_if_exists: #86001

@nikitamikhaylov nikitamikhaylov added this pull request to the merge queue Aug 22, 2025
Merged via the queue into master with commit dfcb527 Aug 22, 2025
121 of 122 checks passed
@nikitamikhaylov nikitamikhaylov deleted the Avogar-patch-8 branch August 22, 2025 13:24
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikitamikhaylov nikitamikhaylov nikitamikhaylov approved these changes

Assignees

@nikitamikhaylov nikitamikhaylov

Labels

pr-ci pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test 03364_estimate_compression_ratio is really flaky

3 participants

@Avogar @nikitamikhaylov @robot-ch-test-poll1