Workflow [PR], commit [827bd37]

Summary: ❌

@zhongyuankai I unfortunately had to revert this PR.

The reason is that it caused a regression with at least two queries in ClickBench. The problem can be easily reproduced:

• download the "hits" data set: https://github.com/ClickHouse/ClickBench/blob/main/clickhouse/benchmark.sh#L40
• create the empty table https://github.com/ClickHouse/ClickBench/blob/main/clickhouse/benchmark.sh#L38
• import the data https://github.com/ClickHouse/ClickBench/blob/main/clickhouse/benchmark.sh#L45
• run
  • Q21: ./clickhouse benchmark --query "SELECT COUNT(*) FROM hits WHERE URL LIKE '%google%';" (docs, the performance dropped on my machine from 5.5k queries per second (QPS) to 3.9k QPS
  • Q23: ./clickhouse benchmark --query "SELECT SearchPhrase, MIN(URL), MIN(Title), COUNT(*) AS c, COUNT(DISTINCT UserID) FROM hits WHERE Title LIKE '%Google%'AND URL NOT LIKE '%.google.%' AND SearchPhrase <> '' GROUP BY SearchPhrase ORDER BY c DESC LIMIT 10;", performance dropped locally from 3.8k QPS to 1.9 QPS.

I can only imagine that this is related to more expensive locking, i.e. this optimization got lost by #85253.

If you have some time and like to help, it would be great if you could profile a bit and check what slows things down. Thanks!

Stateless tests (amd_binary, old analyzer, s3 storage, DatabaseReplicated, parallel)

• 03364_estimate_compression_ratio Test 03364_estimate_compression_ratio is really flaky #85999
• 03573_json_keys_with_dots Fix broken test 03573_json_keys_with_dots #85978
• 03595_alter_drop_column_comment_if_exists started Fix broken test 03595_alter_drop_column_comment_if_exists #86001

Stress test (amd_ubsan)

• Code: 48. DB::Exception: Disk does not support WriteMode::Append. Stress test fails with Disk does not support WriteMode::Append #84669

If you have some time and like to help, it would be great if you could profile a bit and check what slows things down. Thanks!

OK, I'll solve this.