Skip to content

support Iceberg Equality Deletes#85843

Merged
hanfei1991 merged 24 commits intomasterfrom
hanfei/equality-deletes
Aug 21, 2025
Merged

support Iceberg Equality Deletes#85843
hanfei1991 merged 24 commits intomasterfrom
hanfei/equality-deletes

Conversation

@hanfei1991
Copy link
Copy Markdown
Member

@hanfei1991 hanfei1991 commented Aug 18, 2025

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Support Iceberg Equality Deletes

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@hanfei1991 hanfei1991 assigned hanfei1991 and unassigned hanfei1991 Aug 18, 2025
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Aug 18, 2025 •
edited
Loading

Workflow [PR], commit [b5ee0fa]

Summary: ❌

job_name test_name status info comment
Stateless tests (amd_binary, old analyzer, s3 storage, DatabaseReplicated, parallel) failure
03573_json_keys_with_dots FAIL
03364_estimate_compression_ratio FAIL
03595_alter_drop_column_comment_if_exists FAIL
Integration tests (arm_binary, distributed plan, 3/4) failure
test_crash_log/test.py::test_pkill FAIL
test_crash_log/test.py::test_pkill_query_log FAIL

@clickhouse-gh clickhouse-gh bot added the pr-improvement Pull request with some product improvements label Aug 18, 2025
@hanfei1991 hanfei1991 mentioned this pull request Aug 18, 2025
Closed
5 tasks
@hanfei1991 hanfei1991 marked this pull request as ready for review August 19, 2025 13:43
scanhex12
scanhex12 reviewed Aug 21, 2025
View reviewed changes
@hanfei1991
Copy link
Copy Markdown
Member Author

hanfei1991 commented Aug 21, 2025 •
edited
Loading

I have refined the test

  • write more data after deletes
  • deletes with 2 columns and 2 rows

@scanhex12 PTAL

scanhex12
scanhex12 approved these changes Aug 21, 2025
View reviewed changes
src/Storages/ObjectStorage/StorageObjectStorageConfiguration.h

virtual void modifyFormatSettings(FormatSettings &) const {}

virtual bool hasPositionDeleteTransformer(const ObjectInfoPtr & /*object_info*/) const;
Copy link
Copy Markdown
Member

@scanhex12 scanhex12 Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method looks strange because delete files are a feature related only to Iceberg. Don’t fix it now, but I think we should fix this in the future

@hanfei1991
Copy link
Copy Markdown
Member Author

hanfei1991 commented Aug 21, 2025

flaky #85999
other tests are fixed by other prs

@hanfei1991 hanfei1991 added this pull request to the merge queue Aug 21, 2025
Merged via the queue into master with commit 89b3176 Aug 21, 2025
120 of 122 checks passed
@hanfei1991 hanfei1991 deleted the hanfei/equality-deletes branch August 21, 2025 22:30
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-synced-to-cloud The PR is synced to the cloud repo label Aug 21, 2025
@hanfei1991 hanfei1991 mentioned this pull request Jan 13, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scanhex12 scanhex12 scanhex12 approved these changes

Assignees

@scanhex12 scanhex12

Labels

pr-improvement Pull request with some product improvements pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hanfei1991 @scanhex12 @robot-ch-test-poll3