Skip to content

Slightly better test test_restore_replica#84855

Merged
nikitamikhaylov merged 2 commits intomasterfrom
little-bit-better
Aug 7, 2025
Merged

Slightly better test test_restore_replica#84855
nikitamikhaylov merged 2 commits intomasterfrom
little-bit-better

Conversation

@nikitamikhaylov
Copy link
Copy Markdown
Member

@nikitamikhaylov nikitamikhaylov commented Aug 1, 2025

This test is flaky in master: https://play.clickhouse.com/play?user=play#U0VMRUNUIGNoZWNrX25hbWUsIHRlc3RfbmFtZSwgcmVwb3J0X3VybApGUk9NIGNoZWNrcwpXSEVSRSAxCiAgICBBTkQgY2hlY2tfc3RhcnRfdGltZSA+PSBub3coKSAtIElOVEVSVkFMIDI0IEhPVVIKICAgIEFORCAoaGVhZF9yZWYgPSAnbWFzdGVyJyBBTkQgc3RhcnRzV2l0aChoZWFkX3JlcG8sICdDbGlja0hvdXNlLycpKQogICAgQU5EIHRlc3Rfc3RhdHVzICE9ICdTS0lQUEVEJwogICAgQU5EICh0ZXN0X3N0YXR1cyBMSUtFICdGJScgT1IgdGVzdF9zdGF0dXMgTElLRSAnRSUnKSAKICAgIEFORCBjaGVja19zdGF0dXMgIT0gJ3N1Y2Nlc3MnCiAgICBBTkQgdGVzdF9uYW1lIElMSUtFICcldGVzdF9yZXN0b3JlX3JlcGxpY2EvdGVzdC5weSUnCk9SREVSIEJZIGNoZWNrX25hbWUsIHRlc3RfbmFtZSwgY2hlY2tfc3RhcnRfdGltZQ==

During the investigation I found that this test has overridden settings for the backoff in the background pool and logs are polluted with:

2025.07.31 17:56:33.659021 [ 219 ] {BgSchPool::0fbf0b09-b5e9-43ea-8039-ea3550d71ad2} <Debug> default.test_ttl (ReplicatedMergeTreeQueue): Not executing log entry queue-0000000001 for part 1_0_0_1 because merges with TTL are cancelled now.
2025.07.31 17:56:33.661289 [ 194 ] {BgSchPool::1367969d-aaec-4d8c-9e61-6a4f34ff0ce7} <Debug> default.test_ttl (ReplicatedMergeTreeQueue): Not executing log entry queue-0000000001 for part 1_0_0_1 because merges with TTL are cancelled now.
2025.07.31 17:56:33.661792 [ 269 ] {BgSchPool::8211470d-18ff-464a-8ac8-231d25eb40a6} <Debug> default.test_ttl (ReplicatedMergeTreeQueue): Not executing log entry queue-0000000001 for part 1_0_0_1 because merges with TTL are cancelled now.
2025.07.31 17:56:33.662205 [ 33 ] {BgSchPool::2002fea4-becf-44c3-a71a-05c773279307} <Debug> default.test_ttl (ReplicatedMergeTreeQueue): Not executing log entry queue-0000000001 for part 1_0_0_1 because merges with TTL are cancelled now.

I have a suspicion that it might overload the CPU in a tiny container.

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

...

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Aug 1, 2025 •
edited
Loading

Workflow [PR], commit [7f87a9c]

Summary: ✅

@clickhouse-gh clickhouse-gh bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Aug 1, 2025
@bharatnc bharatnc self-assigned this Aug 1, 2025
@nikitamikhaylov
Copy link
Copy Markdown
Member Author

nikitamikhaylov commented Aug 1, 2025 •
edited
Loading

Same, the server was killed. This is being debugged in #84881

❯ tail -n 7 docker.log
replica2-1  | Merging configuration file '/etc/clickhouse-server/config.d/remote_servers.xml'.
replica2-1 exited with code 137
replica1-1 exited with code 0
replica3-1 exited with code 0
zoo3-1 exited with code 0
zoo2-1 exited with code 0
zoo1-1 exited with code 0

@CheSema CheSema mentioned this pull request Aug 1, 2025
Closed
1 task
@nikitamikhaylov nikitamikhaylov added this pull request to the merge queue Aug 7, 2025
Merged via the queue into master with commit aaa9e25 Aug 7, 2025
124 checks passed
@nikitamikhaylov nikitamikhaylov deleted the little-bit-better branch August 7, 2025 21:56
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bharatnc bharatnc bharatnc approved these changes

Assignees

@bharatnc bharatnc

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nikitamikhaylov @bharatnc @robot-ch-test-poll2