Skip to content

Revert Support bloom_filter usage for "has" on const array#84142

Merged
alexey-milovidov merged 2 commits intoClickHouse:masterfrom
shankar-iyer:revert_bloom_filter_has_const_array
Jul 21, 2025
Merged

Revert Support bloom_filter usage for "has" on const array#84142
alexey-milovidov merged 2 commits intoClickHouse:masterfrom
shankar-iyer:revert_bloom_filter_has_const_array

Conversation

@shankar-iyer
Copy link
Copy Markdown
Member

@shankar-iyer shankar-iyer commented Jul 21, 2025

Resolves #84140. Revert #83945

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jul 21, 2025 •
edited
Loading

Workflow [PR], commit [6a8fd27]

Summary: ⏳

job_name test_name status info comment
Stateless tests (amd_tsan, s3 storage, parallel) failure
02561_null_as_default_more_formats FAIL
Scraping minio_audit_logs FAIL
Integration tests (tsan, 5/6) failure
test_storage_s3_queue/test_3.py::test_upgrade_2 FAIL
test_storage_s3_queue/test_3.py::test_processed_file_setting[5] FAIL
test_storage_s3_queue/test_3.py::test_processed_file_setting_distributed[1] FAIL
test_storage_s3_queue/test_3.py::test_commit_on_limit[1] FAIL
test_storage_s3_queue/test_3.py::test_processed_file_setting_distributed[5] FAIL
test_storage_s3_queue/test_3.py::test_commit_on_limit[16] FAIL
test_storage_s3_queue/test_3.py::test_upgrade FAIL
test_storage_s3_queue/test_3.py::test_processed_file_setting[1] FAIL
test_storage_s3_queue/test_3.py::test_settings_check FAIL

@clickhouse-gh clickhouse-gh bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jul 21, 2025
@rschu1ze rschu1ze enabled auto-merge July 21, 2025 13:44
@alexey-milovidov alexey-milovidov merged commit bd889c3 into ClickHouse:master Jul 21, 2025
102 of 123 checks passed
@alexey-milovidov alexey-milovidov self-assigned this Jul 21, 2025
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 21, 2025
@azat azat mentioned this pull request Jul 21, 2025
Merged
@dorki
Copy link
Copy Markdown

dorki commented Jul 21, 2025

@shankar-iyer
i cant open the praktika report mentioned in the issue, can you share the issue with the test?

@azat
Copy link
Copy Markdown
Member

azat commented Jul 21, 2025

@dorki you can take a look at i.e. this one
https://s3.amazonaws.com/clickhouse-test-reports/json.html?REF=master&sha=7fb4e79c0da244985a35f490cb6cf9929d11c11a&name_0=MasterCI&name_1=Stateless%20tests%20%28amd_binary%2C%20ParallelReplicas%2C%20s3%20storage%2C%20parallel%29

Also FYI AFAICS it fails only with parallel replicas

P.S. the report that you've tried just too big, that's why it does not open - #84140 (comment)

@shankar-iyer
Copy link
Copy Markdown
Member Author

shankar-iyer commented Jul 22, 2025

@dorki Yes, the test failed in ParallelReplicas suite. That can be solved by adding SET parallel_replicas_local_plan=1; in the test

Please also take a look at #83724 (comment)

@dorki
Copy link
Copy Markdown

dorki commented Jul 23, 2025

Please also take a look at #83724 (comment)

Thanks, ill create a new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexey-milovidov alexey-milovidov

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

03376_bloom_filter_has_const_array is flaky

5 participants

@shankar-iyer @dorki @azat @alexey-milovidov @robot-clickhouse-ci-2