Skip to content

Handle exceptions properly in periodic parts refresh#84083

Merged
azat merged 1 commit intoClickHouse:masterfrom
azat:refresh-parts-catch-errors
Jul 21, 2025
Merged

Handle exceptions properly in periodic parts refresh#84083
azat merged 1 commit intoClickHouse:masterfrom
azat:refresh-parts-catch-errors

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Jul 20, 2025

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Handle exceptions properly in periodic parts refresh

This code can throw in general, so let's add proper try/catch

Fixes: #50666
Refs: #79033

@azat
Handle exceptions properly in periodic parts refresh
016d8a9 
This code can throw in general, so let's add proper try/catch
@azat azat requested a review from alexey-milovidov July 20, 2025 20:47
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jul 20, 2025 •
edited
Loading

Workflow [PR], commit [016d8a9]

Summary: ❌

job_name test_name status info comment
Finish Workflow failure
python3 ./ci/jobs/scripts/workflow_hooks/new_tests_check.py failure

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Jul 20, 2025
@azat azat mentioned this pull request Jul 20, 2025
Closed
@alexey-milovidov alexey-milovidov self-assigned this Jul 20, 2025
@azat
Copy link
Copy Markdown
Member Author

azat commented Jul 21, 2025

PR / Finish Workflow (pull_request)Failing after 42s

@maxknv is it an issue of CI?

@azat azat enabled auto-merge July 21, 2025 14:32
@azat azat added this pull request to the merge queue Jul 21, 2025
Merged via the queue into ClickHouse:master with commit ce7fad2 Jul 21, 2025
121 of 124 checks passed
@azat azat deleted the refresh-parts-catch-errors branch July 21, 2025 14:51
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 21, 2025
@maxknv
Copy link
Copy Markdown
Member

maxknv commented Jul 22, 2025

PR / Finish Workflow (pull_request)Failing after 42s

@maxknv is it an issue of CI?

no, ci is complaining that no new tests added for pr-bugfix #84083 (comment)

@azat
Copy link
Copy Markdown
Member Author

azat commented Jul 22, 2025

no, ci is complaining that no new tests added for pr-bugfix

@maxknv Thanks! Can you make reports more clear, I remember before it has "bugfix failed - no new test added" or something like this? Or at least in the logs, now I see it, but it is hard to find unless you know what to look for

2025-07-21T00:49:35.2158960Z Run command: [python3 ./ci/jobs/scripts/workflow_hooks/new_tests_check.py]
2025-07-21T00:49:35.2987160Z No new tests have been added
2025-07-21T00:49:35.3133447Z ERROR: command failed, exit code: 1, retry: 0/1

@maxknv
Copy link
Copy Markdown
Member

maxknv commented Jul 22, 2025

all failures with description in the main ci report
image
This change allows not to block merge if new unit tests were added - that was one of the reasons to move this check into finish check, where you don't expect to see it.

@azat azat mentioned this pull request Jul 23, 2025
Closed
@azat azat mentioned this pull request Dec 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@alexey-milovidov alexey-milovidov

Labels

pr-bugfix Pull request with bugfix, not backported by default pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Logical error: Tasks in BackgroundSchedulePool cannot throw

4 participants

@azat @maxknv @alexey-milovidov @robot-clickhouse