no-msan in 00804_test_alter_compression_codecs#83421
Merged
alexey-milovidov merged 1 commit intomasterfrom Jul 15, 2025
Merged
Conversation
Contributor
|
Workflow [PR], commit [4878fde2] Summary: ❌
|
scanhex12
approved these changes
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Saw it fail twice with msan on seemingly unrelated PRs:
It normally takes anywhere between 50s and 270s: https://play.clickhouse.com/play?user=play#U0VMRUNUIGNoZWNrX3N0YXJ0X3RpbWUsIGhlYWRfcmVmLCB0ZXN0X2R1cmF0aW9uX21zLCB0ZXN0X3N0YXR1cywgY2hlY2tfc3RhdHVzLCByZXBvcnRfdXJsCkZST00gY2hlY2tzCldIRVJFIDEKICAgIEFORCBjaGVja19zdGFydF90aW1lID49IG5vdygpIC0gSU5URVJWQUwgMjQwIEhPVVIKICAgIEFORCB0ZXN0X3N0YXR1cyAhPSAnU0tJUFBFRCcKICAgIC0tQU5EICh0ZXN0X3N0YXR1cyBMSUtFICdGJScgT1IgdGVzdF9zdGF0dXMgTElLRSAnRSUnKSAKICAgIC0tQU5EIGNoZWNrX3N0YXR1cyAhPSAnc3VjY2VzcycKICAgIGFuZCBjaGVja19uYW1lID0gJ1N0YXRlbGVzcyB0ZXN0cyAoYW1kX21zYW4sIDEvNCknCiAgICBhbmQgdGVzdF9uYW1lID0gJzAwODA0X3Rlc3RfYWx0ZXJfY29tcHJlc3Npb25fY29kZWNzJwpPUkRFUiBCWSBjaGVja19uYW1lLCB0ZXN0X25hbWUsIGNoZWNrX3N0YXJ0X3RpbWU=
But occasionally times out after something like 350s.
The slow part is a simple MergeTree insert with 300k rows:
In the failed runs the query completes, seemingly normally, server log doesn't have anything interesting for this query.
Idk why it's so slow and inconsistent in MSAN build. This PR just disabled this test in msan. There may or may not be more to investigate here; maybe the server was overloaded by too many tests in parallel and we need to decrease parallelism for asan tests? or maybe the server was overloaded by one particular bad test running in parallel with this one? or there's some performance bug that gets much worse under msan? I didn't investigate.