Continue #70105: Reduce port header memcpy#83381
Merged
Algunenano merged 4 commits intoClickHouse:masterfrom Jul 10, 2025
Merged
Continue #70105: Reduce port header memcpy#83381Algunenano merged 4 commits intoClickHouse:masterfrom
Algunenano merged 4 commits intoClickHouse:masterfrom
Conversation
Co-authored-by: János Benjamin Antal <antaljanosbenjamin@users.noreply.github.com>
Contributor
|
Workflow [PR], commit [9751702] Summary: ❌
|
20 tasks
Member
Author
|
The change makes sense and would avoid excessive copy of headers in pipeline generation (specially noticeable with large pipelines). I'll try to extend it to the full pipeline |
Member
Author
I underestimated how many changes this requires. I'll move it to a different, massive, PR The performance tests are so unstable that's impossible to determine anything. The only test I see has slowed down in both ARM and x86 is |
Member
Author
|
Multiple CI issues already fixed in master. Merging master to confirm it's clean |
Member
Author
|
Merged
via the queue into
ClickHouse:master
with commit Jul 10, 2025
97aa10b
117 of 123 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Minimize memory copy in port headers during pipeline construction. Original PR by heymind
Documentation entry for user-facing changes