Cherry pick #80247 to 25.4: Reduce lock contention in QueryConditionCache#81853
Merged
robot-ch-test-poll2 merged 3 commits intobackport/25.4/80247from Jun 14, 2025
Merged
Cherry pick #80247 to 25.4: Reduce lock contention in QueryConditionCache#81853robot-ch-test-poll2 merged 3 commits intobackport/25.4/80247from
robot-ch-test-poll2 merged 3 commits intobackport/25.4/80247from
Conversation
…ached query conditions need to be updated based on changes to underlying data or configuration. This improves query performance by avoiding unnecessary cache rebuilds while ensuring data consistency when conditions change. The method also helps reduce unnecessary lock contention, improving concurrency in multi-threaded query environments. Performance improvements: - Reduces the "native_queued_spin_lock_slowpath" hotspot of entry->mutex from 76% to 1% with Clickbench Q10 on a 2 x 240 vCPUs system - Increases QPS for Q10 and Q11 by 85% and 89% respectively - Improves overall performance across 43 queries with a geometric mean gain of 8.1% Signed-off-by: Jiebin Sun <jiebin.sun@intel.com> Reviewed-by: Wangyang Guo <wangyang.guo@intel.com>
Reduce lock contention in QueryConditionCache
0a22c47
into
backport/25.4/80247
127 of 131 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original pull-request #80247
This pull-request is a first step of an automated backporting.
It contains changes similar to calling
git cherry-picklocally.If you intend to continue backporting the changes, then resolve all conflicts if any.
Otherwise, if you do not want to backport them, then just close this pull-request.
The check results does not matter at this step - you can safely ignore them.
Note
This pull-request will be merged automatically. Please, do not merge it manually (but if you accidentally did, nothing bad will happen).
Troubleshooting
If the PR was manually reopened after being closed
If this PR is stuck (i.e. not automatically merged after one day), check #80247 for
pr-backports-createdlabel and delete it.Manually merging will do nothing. The
pr-backports-createdlabel prevents the original PR #80247 from being processed.If the conflicts were resolved in a wrong way
If this cherry-pick PR is completely screwed by a wrong conflicts resolution, and you want to recreate it:
pr-cherrypicklabel from the PRYou also need to check the original PR #80247 for
pr-backports-created, and delete if it's presented thereThe PR source
The PR is created in the CI job