Fix DatabaseReplicated for database_replicated_enforce_synchronous_settings=1#81564
Merged
azat merged 2 commits intoClickHouse:masterfrom Jun 12, 2025
Conversation
Contributor
b2aac5a to
a89a451
Compare
…ttings=1 The problem is in combination of database_replicated_enforce_synchronous_settings (since it uses different path in zookeeper, "synced" over "finished") and when DatabaseReplicated already received some queries before the replica has been created, since in this case it is responsibility of DatabaseReplicated to mark those entries as finished, and it knows only about "finished" before, and it leads to undefinite wait from the initiator.
a89a451 to
bc3d379
Compare
tavplubix
approved these changes
Jun 12, 2025
Merged
via the queue into
ClickHouse:master
with commit Jun 12, 2025
b849c9d
119 of 121 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix
DatabaseReplicatedfordatabase_replicated_enforce_synchronous_settings=1The problem is in combination of
database_replicated_enforce_synchronous_settings(since it uses different path in zookeeper, "synced" over "finished")
and when DatabaseReplicated already received some queries before the
replica has been created, since in this case it is responsibility of
DatabaseReplicated to mark those entries as finished, and it knows only
about "finished" before, and it leads to indefinite wait from the
initiator.
Fixes: #81382
Fixes: #81559
database_replicated_enforce_synchronous_settingsintroduced in: #37198