Conversation
Contributor
tuanpach
reviewed
May 27, 2025
| with pytest.raises(QueryRuntimeException): | ||
| node3.query(f"SELECT * FROM remote('{node_name}', 'system', 'one')") | ||
| else: | ||
| logging.warning("Spent too much time on restart, skip short-update test") |
Member
There was a problem hiding this comment.
From my understanding, if restart_elapsed >=8, the DNS cache might be refreshed, and the query might connect to the node. Is it correct?
Member
Author
There was a problem hiding this comment.
Yes, I've added a comment about it
| restart_elapsed = time.time() - restart_start_time | ||
|
|
||
| if restart_elapsed < 8: | ||
| with pytest.raises(QueryRuntimeException): |
Member
There was a problem hiding this comment.
I think we can use node3.query_and_get_error instead of with pytest.raises(QueryRuntimeException):
Member
Author
There was a problem hiding this comment.
The error message may vary. Better to keep it that way
tuanpach
approved these changes
May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Closes #75982