Skip to content

Backport #79847 to 24.8: fix float NaN sorting order on some platforms#80582

Merged
GrigoryPervakov merged 1 commit into24.8from
backport/24.8/79847
May 23, 2025
Merged

Backport #79847 to 24.8: fix float NaN sorting order on some platforms#80582
GrigoryPervakov merged 1 commit into24.8from
backport/24.8/79847

Conversation

@robot-clickhouse-ci-1
Copy link
Copy Markdown
Contributor

@robot-clickhouse-ci-1 robot-clickhouse-ci-1 commented May 20, 2025

Original pull-request #79847
Cherry-pick pull-request #80525

This pull-request is a last step of an automated backporting.
Treat it as a standard pull-request: look at the checks and resolve conflicts.
Merge it only if you intend to backport changes to the target branch, otherwise just close it.

The PR source

The PR is created in the CI job

@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added pr-backport Changes, backported to release branch. Do not use manually - automated use only! pr-bugfix Pull request with bugfix, not backported by default labels May 20, 2025
@robot-ch-test-poll
Copy link
Copy Markdown
Contributor

robot-ch-test-poll commented May 20, 2025 •
edited by robot-ch-test-poll1
Loading

This is an automated comment for commit 3ab8247 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Successful checks
Check nameDescriptionStatus
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success

@GrigoryPervakov
Copy link
Copy Markdown
Member

GrigoryPervakov commented May 23, 2025

Failed tests:
test_dictionaries_all_*
test_storage_mongodb
test_table_function_mongodb
All are flaky and unrelated

@GrigoryPervakov GrigoryPervakov merged commit 55330db into 24.8 May 23, 2025
44 of 60 checks passed
@GrigoryPervakov GrigoryPervakov deleted the backport/24.8/79847 branch May 23, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@GrigoryPervakov GrigoryPervakov

@divanik divanik

Labels

pr-backport Changes, backported to release branch. Do not use manually - automated use only! pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@robot-clickhouse-ci-1 @robot-ch-test-poll @GrigoryPervakov @divanik @robot-clickhouse