Skip to content

Revert "rework pushing to views #77309"#79898

Merged
tavplubix merged 2 commits intomasterfrom
revert-pushing-to-views
May 7, 2025
Merged

Revert "rework pushing to views #77309"#79898
tavplubix merged 2 commits intomasterfrom
revert-pushing-to-views

Conversation

@nikitamikhaylov
Copy link
Copy Markdown
Member

@nikitamikhaylov nikitamikhaylov commented May 6, 2025 •
edited
Loading

According to a tiny research this PR made segfaults to reproduce more often. The problem itself existed before and was firing in random PRs with similar sympthoms.

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

This reverts #77309

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@nikitamikhaylov
Revert "Merge pull request #77309 from ClickHouse/chesema-deduplicate…
8c154f2 
…-sync-inserts"

This reverts commit 120768e, reversing
changes made to 0d42a5c.
@nikitamikhaylov
Fix build
45c4636
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented May 6, 2025

Workflow [PR], commit [45c4636]

@clickhouse-gh clickhouse-gh bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label May 6, 2025
@nikitamikhaylov nikitamikhaylov mentioned this pull request May 6, 2025
Closed
@Algunenano Algunenano self-assigned this May 7, 2025
@tavplubix tavplubix enabled auto-merge May 7, 2025 12:03
@tavplubix tavplubix added this pull request to the merge queue May 7, 2025
Merged via the queue into master with commit 1dedbeb May 7, 2025
115 of 122 checks passed
@tavplubix tavplubix deleted the revert-pushing-to-views branch May 7, 2025 12:18
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-synced-to-cloud The PR is synced to the cloud repo label May 7, 2025
@CheSema CheSema mentioned this pull request May 8, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Algunenano Algunenano Algunenano approved these changes

Assignees

@Algunenano Algunenano

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nikitamikhaylov @Algunenano @tavplubix @robot-ch-test-poll1