Skip to content

Fix 2 cases of "Logical Error: Can't set alias of * of Asterisk on alias"#79505

Merged
nikitamikhaylov merged 5 commits intoClickHouse:masterfrom
Algunenano:default_quick
May 10, 2025
Merged

Fix 2 cases of "Logical Error: Can't set alias of * of Asterisk on alias"#79505
nikitamikhaylov merged 5 commits intoClickHouse:masterfrom
Algunenano:default_quick

Conversation

@Algunenano
Copy link
Copy Markdown
Member

@Algunenano Algunenano commented Apr 23, 2025

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix 2 cases of "Logical Error: Can't set alias of * of Asterisk on alias"

Nor marking as critical since backporting is not worth it (and might be risky)
Closes #78542

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Apr 23, 2025 •
edited
Loading

Workflow [PR], commit [52b2bc7]

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Apr 23, 2025
@Algunenano
Copy link
Copy Markdown
Member Author

Algunenano commented Apr 24, 2025

Breaks some queries with the old analyzer. Need to investigate

@nikitamikhaylov
Copy link
Copy Markdown
Member

nikitamikhaylov commented May 7, 2025

Let's continue? 🥹

@Algunenano
Copy link
Copy Markdown
Member Author

Algunenano commented May 7, 2025

The PR is ready for review and fixes 2 bugs

@nikitamikhaylov nikitamikhaylov self-assigned this May 7, 2025
@Algunenano
Copy link
Copy Markdown
Member Author

Algunenano commented May 9, 2025

Bugfix validation is broken -> #80029
Integration tests (tsan, 1/6) -> test_storage_rabbitmq failures (again and again). Totally unrelated

@nikitamikhaylov nikitamikhaylov added the 🍃 green ci 🌿 Fixing flaky tests in CI label May 10, 2025
@nikitamikhaylov nikitamikhaylov added this pull request to the merge queue May 10, 2025
Merged via the queue into ClickHouse:master with commit ca36de6 May 10, 2025
117 of 121 checks passed
@robot-ch-test-poll robot-ch-test-poll added the pr-synced-to-cloud The PR is synced to the cloud repo label May 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikitamikhaylov nikitamikhaylov nikitamikhaylov approved these changes

Assignees

@nikitamikhaylov nikitamikhaylov

Labels

🍃 green ci 🌿 Fixing flaky tests in CI pr-bugfix Pull request with bugfix, not backported by default pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Logical Error: Can't set alias of * of Asterisk on alias

3 participants

@Algunenano @nikitamikhaylov @robot-ch-test-poll