Skip to content

ch and clickhouse shortcuts are now responsive#79422

Closed
aaaengel wants to merge 8 commits intoClickHouse:masterfrom
aaaengel:issue_65252
Closed

ch and clickhouse shortcuts are now responsive#79422
aaaengel wants to merge 8 commits intoClickHouse:masterfrom
aaaengel:issue_65252

Conversation

@aaaengel
Copy link
Copy Markdown
Contributor

Changelog category:

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

ch and clickhouse shortcuts are now responsive to --host, -h, --port, --user, -u, --password arguments and to connection string. When passing these arguments it runs clickhouse-client.
Closes #65252

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 22, 2025

CLA assistant check
All committers have signed the CLA.

@aaaengel aaaengel changed the title Issue 65252 ch and clickhouse shortcuts are now responsive Apr 22, 2025
@alexey-milovidov alexey-milovidov added the can be tested Allows running workflows for external contributors label Apr 27, 2025
.clang-format Outdated
DerivePointerAlignment: false
DisableFormat: false
IndentRequiresClause: false
#IndentRequiresClause: false
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a problem locally. Will change it.

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Apr 27, 2025

Workflow [PR], commit [1b3ba09]

@clickhouse-gh clickhouse-gh bot added the pr-improvement Pull request with some product improvements label Apr 27, 2025
/// Currently we will prefer the latter option.
std::pair<std::string_view, MainFunc> clickhouse_applications[] =
{
std::pair<std::string_view, MainFunc> clickhouse_applications[] = {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not reformat the existing code.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, guess it is because clang-format command. I will provide all these changes

@alexey-milovidov
Copy link
Copy Markdown
Member

Continued in #81509.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

can be tested Allows running workflows for external contributors pr-improvement Pull request with some product improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unify calling of calling client or local with clickhouse and ch shortcuts

3 participants