Fix Digest does not match (from Replicated database) on CI#78741
Merged
azat merged 7 commits intoClickHouse:masterfrom Apr 8, 2025
Merged
Fix Digest does not match (from Replicated database) on CI#78741azat merged 7 commits intoClickHouse:masterfrom
azat merged 7 commits intoClickHouse:masterfrom
Conversation
Contributor
azat
commented
Apr 7, 2025
Member
Author
tavplubix
approved these changes
Apr 7, 2025
The probelm was the 03001_matview_columns_after_modify_query test, and
only in stress tests, since there we don't set
database_replicated_always_detach_permanently=1, and so DETACH that is
done before playing with metadata on disk fails, and after this this
LOGICAL_ERROR will happen:
$ ../tests/clickhouse-test --client-option distributed_ddl_output_mode=none --replicated-database 03001_matview_columns_after_modify_query
...
Code: 49. DB::Exception: Received from localhost:9000. DB::Exception: Digest does not match. (LOGICAL_ERROR)
(query: ALTER TABLE mv MODIFY QUERY SELECT Timestamp as timestamp, c1 || c2 as c12 FROM src)
So, let's simply disable it.
Note it does not make a lot of sense to fix this DETACH error (with i.e.
PERMANTENTLY) since we need to modify the data in ZooKeeper additionally
for Replicated, plus it still can be racy if other tests will have "mv"
table.
We already have tryCompareLocalAndZooKeeperTablesAndDumpDiffForDebugOnly() that compares local vs zookeeper
Previously it prints only in-memory and in ZooKeeper, but all of our problems on CI was when on-disk differs, so let's add it as well And also I simplified (I hope) code a little.
tavplubix
approved these changes
Apr 8, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
The probelm was the 03001_matview_columns_after_modify_query test, and
only in stress tests, since there we don't set
database_replicated_always_detach_permanently=1, and so DETACH that is
done before playing with metadata on disk fails, and after this this
LOGICAL_ERROR will happen:
So, let's simply disable it.
Note it does not make a lot of sense to fix this DETACH error (with i.e.
PERMANTENTLY) since we need to modify the data in ZooKeeper additionally
for Replicated, plus it still can be racy if other tests will have "mv"
table.
Fixes: #64936