Merged
Conversation
Contributor
thevar1able
reviewed
Mar 7, 2025
antonio2368
reviewed
Mar 7, 2025
antonio2368
approved these changes
Mar 10, 2025
Merged
via the queue into
ClickHouse:master
with commit Mar 10, 2025
7b85ead
123 of 126 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is follow-up to #69236. It removes the mutex in theEntryclass. It was only necessary because entries could be written while the key was already inserted in the cache and read in parallel. Now, the entry is inserted atomically.Review note: Only commit 743d22a is relevant.Changelog category (leave one):