Skip to content

Fix lifetime of callback in threadPoolCallbackRunner#74267

Merged
CurtizJ merged 2 commits intoClickHouse:masterfrom
CurtizJ:fix-thread-pool-runner-lifetime
Jan 9, 2025
Merged

Fix lifetime of callback in threadPoolCallbackRunner#74267
CurtizJ merged 2 commits intoClickHouse:masterfrom
CurtizJ:fix-thread-pool-runner-lifetime

Conversation

@CurtizJ
Copy link
Copy Markdown
Member

@CurtizJ CurtizJ commented Jan 7, 2025 •
edited
Loading

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Fixes #74287.

CI Settings (Only check the boxes if you know what you are doing)

All builds in Builds_1 and Builds_2 stages are always mandatory
and will run independently of the checks below:

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64
  • Exclude: All with release
  • Exclude: All with debug
  • Run only fuzzers related jobs (libFuzzer fuzzers, AST fuzzers, BuzzHouse, etc.)
  • Exclude: AST fuzzers
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@robot-ch-test-poll robot-ch-test-poll added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jan 7, 2025
@robot-ch-test-poll
Copy link
Copy Markdown
Contributor

robot-ch-test-poll commented Jan 7, 2025 •
edited by robot-clickhouse-ci-1
Loading

This is an automated comment for commit ec23f7f with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
BuzzHouse (asan)There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
BuzzHouse (debug)There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
BuzzHouse (msan)There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
BuzzHouse (tsan)There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
BuzzHouse (ubsan)There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns ClickBench with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@antonio2368 antonio2368 self-assigned this Jan 8, 2025
antonio2368
antonio2368 reviewed Jan 8, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@antonio2368 antonio2368 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have an example of failure which is fixed by this?
IMO the point of ThreadPoolCallbackRunnerLocal is to be local so it should be also in some limited scope and with that should be destructed with it's callback after tasks are executed.

@antonio2368
Copy link
Copy Markdown
Member

antonio2368 commented Jan 8, 2025

I assume it's related to this #74287
It took me a while to understand but the fix makes sense

@CurtizJ
Copy link
Copy Markdown
Member Author

CurtizJ commented Jan 8, 2025

Yes, it is related to #74287.

Currently, the following execution sequence may happen:

caller thread:              |             | waitForAllToFinish returned | runner destroyed |                    |                    |
thread from pool:  callback | promise.set |                             |                  | callback destroyed | task_func returned |

It happens because the task function is moved to the thread pool, and its lifetime can extend the local runner's lifetime. I think this is wrong in general and may be dangerous.

In #74287, we are waiting for the parallel removal of parts. The vector of parts is held by lambda, and when it is destroyed, we can already return from waitForAllToFinish and from clearPartsFromFilesystem and delete the table object.

@CurtizJ
Copy link
Copy Markdown
Member Author

CurtizJ commented Jan 9, 2025

Failed integration tests are flaky in master.

@CurtizJ CurtizJ added this pull request to the merge queue Jan 9, 2025
Merged via the queue into ClickHouse:master with commit 1552379 Jan 9, 2025
@CurtizJ CurtizJ deleted the fix-thread-pool-runner-lifetime branch January 9, 2025 12:46
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonio2368 antonio2368 antonio2368 approved these changes

Assignees

@antonio2368 antonio2368

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ASAN: heap-use-after-free in the primary index cache prewarm

4 participants

@CurtizJ @robot-ch-test-poll @antonio2368 @robot-ch-test-poll1