Skip to content

Improve the waiting mechanism for keeper in integration tests#74076

Merged
antonio2368 merged 5 commits intoClickHouse:masterfrom
azat:itests/keeper-retry
Jan 7, 2025
Merged

Improve the waiting mechanism for keeper in integration tests#74076
antonio2368 merged 5 commits intoClickHouse:masterfrom
azat:itests/keeper-retry

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Jan 2, 2025

  • Add connection_retry/command_retry
  • Improve wait_until_connected to check that keeper can establish new sessions as well

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

CI:

@azat azat added the 🍃 green ci 🌿 Fixing flaky tests in CI label Jan 2, 2025
@azat azat mentioned this pull request Jan 2, 2025
Merged
@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jan 2, 2025
@robot-ch-test-poll1
Copy link
Copy Markdown
Contributor

robot-ch-test-poll1 commented Jan 2, 2025 •
edited
Loading

This is an automated comment for commit 9657329 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc❌ failure
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Successful checks
Check nameDescriptionStatus
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@azat azat force-pushed the itests/keeper-retry branch 4 times, most recently from b8c3e28 to 21f310c Compare January 3, 2025 18:10
azat added 5 commits January 5, 2025 17:41
@azat
tests: improve helpers for waiting for keeper to became ready
dd4e180 
4LW commands not always enough to ensure that keeper can server regular
queries, since for regular queries it need to create session as well.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
@azat
tests: add connection/command for KazooClient for Keeper
fdd3511 
CI: https://s3.amazonaws.com/clickhouse-test-reports/72598/a7e97aa3a2dd13ba4fd5c2e37ff7299187d85bd8/integration_tests__tsan__%5B3_6%5D.html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
@azat
tests: remove unused close_keeper_socket()
0eb2f35 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
@azat
tests: remove copy paste of get_keeper_socket()
4a18643 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
@azat
tests: disable keeper sessions check for test_keeper_disks
9657329 
CI: https://s3.amazonaws.com/clickhouse-test-reports/74076/21f310c99887e2d3189555aa584ba0c655087435/integration_tests__asan__old_analyzer__[6_6].html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
@azat azat force-pushed the itests/keeper-retry branch from 6404d44 to 9657329 Compare January 5, 2025 16:41
@azat
Copy link
Copy Markdown
Member Author

azat commented Jan 6, 2025

Integration tests (aarch64) [2/6] — fail: 1, passed: 520

Integration tests (tsan) [1/6] — fail: 41, passed: 117

  • test_storage_kafka

Integration tests flaky check (asan) — Failed tests found: error: 0, passed: 652, fail: 168, skipped: 0, broken: 0, not_fail: 0

The problem is that the tests are not idempotent, and it is not that easy to do this (for some of them), so I would suggest to do this separately

@azat
Copy link
Copy Markdown
Member Author

azat commented Jan 7, 2025

Can someone please take a look?

@antonio2368 antonio2368 self-assigned this Jan 7, 2025
antonio2368
antonio2368 approved these changes Jan 7, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@antonio2368 antonio2368 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't seem worse

@antonio2368 antonio2368 added this pull request to the merge queue Jan 7, 2025
Merged via the queue into ClickHouse:master with commit 9882160 Jan 7, 2025
@azat azat deleted the itests/keeper-retry branch January 7, 2025 14:22
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonio2368 antonio2368 antonio2368 approved these changes

Assignees

@antonio2368 antonio2368

Labels

🍃 green ci 🌿 Fixing flaky tests in CI pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@azat @robot-ch-test-poll1 @antonio2368 @robot-clickhouse @robot-ch-test-poll4