Flush progress frequently in the JSONEachRowWithProgress format (2)#73834
Merged
alexey-milovidov merged 9 commits intomasterfrom Dec 27, 2024
Merged
Flush progress frequently in the JSONEachRowWithProgress format (2)#73834alexey-milovidov merged 9 commits intomasterfrom
alexey-milovidov merged 9 commits intomasterfrom
Conversation
Contributor
|
This is an automated comment for commit 11404ac with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
20 tasks
22 tasks
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
JSONEachRowWithProgresswill write the progress whenever the progress happens. In previous versions, the progress was shown only after each block of the result, which made it useless. Change the way how the progress is displayed: it will not show zero values. Keep in mind that the progress is sent even if it happens frequently. It can generate a significant volume of traffic. Keep in mind that the progress is not flushed when the output is compressed. This closes #70800.I've also discovered a few idiosyncracies in the implementation:
result_rowsandresult_bytesare not updated at all;elapsed_nsis not updated either.CI Settings (Only check the boxes if you know what you are doing):