Remove asterisk_left_columns_only setting#7335
Merged
4ertus2 merged 2 commits intoClickHouse:masterfrom Oct 16, 2019
Merged
Conversation
4ertus2
commented
Oct 15, 2019
| { | ||
| bool found = false; | ||
| for (const auto & column_name : source_columns) | ||
| for (const auto & column : source_columns) |
Contributor
Author
There was a problem hiding this comment.
It's strange but if we change ordered source_columns to unordered source_columns_set with the same data we get an error with names resolving.
Update: the most probable reason is an alias column in source_columns_set and general one in source_columns. If we have no columns to select we should add not an alias here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Category (leave one):
Short description (up to few sentences):
Remove legacy
asterisk_left_columns_onlysetting (it was disabled by default).Detailed description (optional):
You can use qualified asterisks instead:
select t.* from t join u.