Skip to content

Revert "Resubmit #68682"#72421

Merged
Algunenano merged 1 commit intomasterfrom
revert-71577-vdimir/join_select_inner_table
Nov 25, 2024
Merged

Revert "Resubmit #68682"#72421
Algunenano merged 1 commit intomasterfrom
revert-71577-vdimir/join_select_inner_table

Conversation

@Algunenano
Copy link
Copy Markdown
Member

@Algunenano Algunenano commented Nov 25, 2024

Reverts #71577

Bug found by SQLancer:

DROP DATABASE IF EXISTS database5TLPGroupBy;
CREATE DATABASE IF NOT EXISTS database5TLPGroupBy;
USE database5TLPGroupBy;
CREATE TABLE IF NOT EXISTS database5TLPGroupBy.t0 (c0 String, c1 Int32, c2 Int32) ENGINE = Log() ;
CREATE TABLE IF NOT EXISTS database5TLPGroupBy.t1 (c0 String, c1 String, c2 String) ENGINE = Memory() ;
CREATE TABLE database5TLPGroupBy.t2 (c0 String) ENGINE = Memory() ;
CREATE TABLE database5TLPGroupBy.t3 (c0 Int32, c1 String, c2 Int32) ENGINE = Memory() ;
CREATE TABLE IF NOT EXISTS database5TLPGroupBy.t4 (c0 String) ENGINE = Memory() ;
INSERT INTO t4(c0) VALUES ('eBZ?J.N');

SELECT (sqrt ((((- (t3.c2)))-(t3.c2)))) FROM t3 RIGHT ANTI JOIN t1 AS right_0 ON ((t3.c1)=(right_0.c0))

Code: 49. DB::Exception: Unexpected number of columns in result sample block: 2 expected 1 ([__table1.c2, __table1.c1] + [] + []): While executing JoiningTransform. (LOGICAL_ERROR)

@Algunenano Algunenano enabled auto-merge November 25, 2024 18:21
@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Nov 25, 2024
@robot-ch-test-poll3
Copy link
Copy Markdown
Contributor

robot-ch-test-poll3 commented Nov 25, 2024

This is an automated comment for commit 4585a62 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success

@Algunenano Algunenano added this pull request to the merge queue Nov 25, 2024
@qoega qoega added the sqlancer Issue found by SQLancer tool label Nov 25, 2024
Merged via the queue into master with commit b0cd933 Nov 25, 2024
@Algunenano Algunenano deleted the revert-71577-vdimir/join_select_inner_table branch November 25, 2024 19:11
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Nov 25, 2024
@vdimir vdimir assigned vdimir and unassigned vdimir Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo sqlancer Issue found by SQLancer tool

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants