Skip to content

Add minmax indices by default#72090

Merged
rschu1ze merged 47 commits intomasterfrom
Secondary_indices_by_default
Jan 7, 2025
Merged

Add minmax indices by default#72090
rschu1ze merged 47 commits intomasterfrom
Secondary_indices_by_default

Conversation

@SmitaRKulkarni
Copy link
Copy Markdown
Member

@SmitaRKulkarni SmitaRKulkarni commented Nov 19, 2024 •
edited by rschu1ze
Loading

Related to #70605 (but does not resolve it yet because of #72090 (comment))

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Add the ability to create min-max (skipping) indices by default for columns managed by MergeTree using settings enable_minmax_index_for_all_numeric_columns (for numeric columns) and enable_minmax_index_for_all_string_columns (for string columns). For now, both settings are disabled, so there is no behavior change yet.

Documentation entry for user-facing changes

  • [ X ] Documentation is written (mandatory for new features)

@SmitaRKulkarni SmitaRKulkarni marked this pull request as draft November 19, 2024 15:21
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-feature Pull request with new product feature label Nov 19, 2024
@robot-clickhouse-ci-2
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-2 commented Nov 19, 2024 •
edited by robot-ch-test-poll1
Loading

This is an automated comment for commit d974884 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns ClickBench with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@alesapin alesapin self-assigned this Nov 20, 2024
@rschu1ze

This comment was marked as resolved.

Sign in to view
@rschu1ze rschu1ze changed the title [WIP]Add secondary indices for all minmax columns [WIP]Add minmax indices by default Nov 26, 2024
@SmitaRKulkarni SmitaRKulkarni changed the title [WIP]Add minmax indices by default Add minmax indices by default Nov 29, 2024
@SmitaRKulkarni SmitaRKulkarni marked this pull request as ready for review November 29, 2024 16:34
rschu1ze
rschu1ze reviewed Dec 2, 2024
View reviewed changes
@rschu1ze rschu1ze assigned rschu1ze and unassigned alesapin Dec 19, 2024
rschu1ze

This comment was marked as resolved.

Sign in to view

@alexey-milovidov alexey-milovidov mentioned this pull request Dec 31, 2024
Closed
76 tasks
@rschu1ze
Copy link
Copy Markdown
Member

rschu1ze commented Jan 7, 2025

Failing test 01700_deltasum is unrelated (#74240)

@rschu1ze rschu1ze added this pull request to the merge queue Jan 7, 2025
Merged via the queue into master with commit 72488a3 Jan 7, 2025
@rschu1ze rschu1ze deleted the Secondary_indices_by_default branch January 7, 2025 15:26
@tavplubix tavplubix mentioned this pull request Jan 7, 2025
Merged
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jan 7, 2025
@rschu1ze rschu1ze mentioned this pull request Jan 7, 2025
Merged
@azat azat mentioned this pull request Feb 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rschu1ze rschu1ze rschu1ze approved these changes

Assignees

@rschu1ze rschu1ze

Labels

pr-feature Pull request with new product feature pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@SmitaRKulkarni @robot-clickhouse-ci-2 @rschu1ze @alesapin @robot-ch-test-poll2 @robot-clickhouse-ci-1