Skip to content

Fix missing cluster startup for test_quorum_inserts::test_insert_quorum_with_keeper_fail#71418

Merged
divanik merged 9 commits intoClickHouse:masterfrom
azat:tests/fix-test_quorum_inserts
Nov 7, 2024
Merged

Fix missing cluster startup for test_quorum_inserts::test_insert_quorum_with_keeper_fail#71418
divanik merged 9 commits intoClickHouse:masterfrom
azat:tests/fix-test_quorum_inserts

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Nov 4, 2024 •
edited
Loading 

    def test_insert_quorum_with_keeper_loss_connection():
>       zero.query(
            "DROP TABLE IF EXISTS test_insert_quorum_with_keeper_fail ON CLUSTER cluster"
        )
    def query(
>       return self.client.query(
E       AttributeError: 'NoneType' object has no attribute 'query'

CI: https://s3.amazonaws.com/clickhouse-test-reports/71406/8b3ce129456a1f85839a48538780639e2e3c3020/integration_tests__asan__old_analyzer__[6_6]//home/ubuntu/actions-runner/_work/_temp/test/output_dir/integration_run_parallel3_0.log

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@azat
Fix missing cluster startup for test_quorum_inserts::test_insert_quor…
24a7e0f 
…um_with_keeper_fail

    def test_insert_quorum_with_keeper_loss_connection():
>       zero.query(
            "DROP TABLE IF EXISTS test_insert_quorum_with_keeper_fail ON CLUSTER cluster"
        )
    def query(
>       return self.client.query(
E       AttributeError: 'NoneType' object has no attribute 'query'

CI: https://s3.amazonaws.com/clickhouse-test-reports/71406/8b3ce129456a1f85839a48538780639e2e3c3020/integration_tests__asan__old_analyzer__[6_6]//home/ubuntu/actions-runner/_work/_temp/test/output_dir/integration_run_parallel3_0.log
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
@azat azat changed the title Fix missing cluster startup for test_quorum_inserts::test_insert_quor… Fix missing cluster startup for test_quorum_inserts::test_insert_quorum_with_keeper_fail Nov 4, 2024
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Nov 4, 2024
@azat azat mentioned this pull request Nov 4, 2024
Merged
@robot-ch-test-poll4
Copy link
Copy Markdown
Contributor

robot-ch-test-poll4 commented Nov 4, 2024 •
edited by robot-ch-test-poll1
Loading

This is an automated comment for commit 8bb656d with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc❌ failure
Successful checks
Check nameDescriptionStatus
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@antaljanosbenjamin antaljanosbenjamin self-assigned this Nov 4, 2024
@azat
Copy link
Copy Markdown
Member Author

azat commented Nov 4, 2024

Integration tests (asan, old analyzer) [6/6] — fail: 4, passed: 514

@cwurm cwurm mentioned this pull request Nov 5, 2024
Merged
@rschu1ze rschu1ze mentioned this pull request Nov 5, 2024
Merged
@yariks5s yariks5s mentioned this pull request Nov 5, 2024
Merged
21 tasks
@divanik divanik self-assigned this Nov 5, 2024
antaljanosbenjamin
antaljanosbenjamin reviewed Nov 5, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@antaljanosbenjamin antaljanosbenjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you missed test_insert_quorum_with_drop_partition and test_insert_quorum_with_move_partition tests.

@antaljanosbenjamin
Copy link
Copy Markdown
Member

antaljanosbenjamin commented Nov 6, 2024

test_quorum_inserts/test.py::test_insert_quorum_with_keeper_loss_connection failed on flaky test check. Need to investigate why.

@divanik
Copy link
Copy Markdown
Member

divanik commented Nov 6, 2024

@hanfei1991, it seems that this this is yours. I am afraid we need your help

@divanik
Copy link
Copy Markdown
Member

divanik commented Nov 6, 2024 •
edited
Loading

Locally I have the similar error: https://pastila.nl/?00607e35/d79d0484b8aac663fe7c3d4c725936c7#NxwGdT+1aDCO2i0xMz3VvQ==

@divanik divanik mentioned this pull request Nov 6, 2024
Closed
@divanik
Copy link
Copy Markdown
Member

divanik commented Nov 7, 2024

We reached an agreement that it is ok to merge the test even with failed flaky check because test wasn't successful before in case it is run several times. Created an issue about this: #71533

This PR changes only one test file. All tests from it are successful except the last one which will be successful in master cause run once. That's why I consider it as a safe operation to override Mergeable Check.

@divanik divanik added this pull request to the merge queue Nov 7, 2024
Merged via the queue into ClickHouse:master with commit 7ea3bcd Nov 7, 2024
@azat azat deleted the tests/fix-test_quorum_inserts branch November 7, 2024 12:48
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antaljanosbenjamin antaljanosbenjamin antaljanosbenjamin approved these changes

@divanik divanik divanik left review comments

Assignees

@antaljanosbenjamin antaljanosbenjamin

@divanik divanik

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@azat @robot-ch-test-poll4 @antaljanosbenjamin @divanik @robot-clickhouse @robot-ch-test-poll3 @devcrafter