Skip to content

Add new function arrayZipUnaligned#69030

Merged
CurtizJ merged 8 commits intoClickHouse:masterfrom
bigo-sg:improve_array_zip
Sep 5, 2024
Merged

Add new function arrayZipUnaligned#69030
CurtizJ merged 8 commits intoClickHouse:masterfrom
bigo-sg:improve_array_zip

Conversation

@taiyang-li
Copy link
Copy Markdown
Contributor

@taiyang-li taiyang-li commented Aug 28, 2024 •
edited
Loading

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Add new function arrayZipUnaligned for spark compatiablity(arrays_zip), which allowed unaligned arrays based on original arrayZip.

SELECT arrayZipUnaligned([1], [1, 2, 3])

Query id: 3ecfa2db-9608-4b39-9953-bb794fe8eae0

   ┌─arrayZipUnaligned([1], [1, 2, 3])─┐
1. │ [(1,1),(NULL,2),(NULL,3)]         │
   └───────────────────────────────────┘

1 row in set. Elapsed: 0.002 sec.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Run only fuzzers related jobs (libFuzzer fuzzers, AST fuzzers, etc.)
  • Exclude: AST fuzzers
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-feature Pull request with new product feature label Aug 28, 2024
@robot-ch-test-poll1
Copy link
Copy Markdown
Contributor

robot-ch-test-poll1 commented Aug 28, 2024 •
edited by robot-ch-test-poll
Loading

This is an automated comment for commit 4bd9e10 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@taiyang-li taiyang-li mentioned this pull request Aug 28, 2024
Merged
@fm4v
Copy link
Copy Markdown
Member

fm4v commented Aug 28, 2024

Hi! Tests missing

@CurtizJ CurtizJ self-assigned this Aug 28, 2024
@taiyang-li taiyang-li marked this pull request as draft August 29, 2024 01:46
@taiyang-li
Copy link
Copy Markdown
Contributor Author

taiyang-li commented Aug 29, 2024

Hi! Tests missing

Sorry, I'll turn it into draft status before I'm ready.

@taiyang-li taiyang-li marked this pull request as ready for review September 2, 2024 04:28
@taiyang-li
Copy link
Copy Markdown
Contributor Author

taiyang-li commented Sep 2, 2024

@fm4v this pr is ready for review now

@fm4v
Copy link
Copy Markdown
Member

fm4v commented Sep 2, 2024 •
edited
Loading

Fuzzer error https://s3.amazonaws.com/clickhouse-test-reports/69030/bd0ddf85eb987517e99edc467a2206ad4033f64f/ast_fuzzer__asan_.html

SELECT DISTINCT concat(concat(concat(arrayZipUnaligned(materialize(['g', 'h', 'i'])), (1, 2, 3), 1, ('a', 'b', 'c')), arrayZipUnaligned(['a']), 2), (1, 'y')) FROM system.parts)

2024.09.02 11:58:02.738931 [ 881 ] {346f7792-f203-40b7-8a4b-4772c0e2a1d0} <Fatal> : Logical error: 'offsets_column has data inconsistent with nested_column. Data size: 741, last offset: 3'.
2024.09.02 11:58:02.791070 [ 881 ] {346f7792-f203-40b7-8a4b-4772c0e2a1d0} <Fatal> : Stack trace (when copying this message, always include the lines below):

2024.09.02 11:58:02.791767 [ 1414 ] {} <Fatal> BaseDaemon: ########## Short fault info ############
2024.09.02 11:58:02.791845 [ 1414 ] {} <Fatal> BaseDaemon: (version 24.9.1.1600, build id: 8BE2A4CA9BB6DEF75A913D2354E944F21D73618B, git hash: f87bae407053e1d66480982191ea9c506e4302b5, architecture: x86_64) (from thread 881) Received signal 6
2024.09.02 11:58:02.791900 [ 1414 ] {} <Fatal> BaseDaemon: Signal description: Aborted
2024.09.02 11:58:02.791931 [ 1414 ] {} <Fatal> BaseDaemon: 
2024.09.02 11:58:02.791983 [ 1414 ] {} <Fatal> BaseDaemon: Stack trace: 0x000055df90db140d 0x000055df913a0083 0x00007f0e0d5fd520 0x00007f0e0d6519fd 0x00007f0e0d5fd476 0x00007f0e0d5e37f3 0x000055df90d3c56b 0x000055df90d3e031 0x000055df8097b445 0x000055df847a095a 0x000055dfa0a62d91 0x000055df903314ff 0x000055df90330232 0x000055df9032d93c 0x000055df809b6115 0x000055df82c4e31b 0x000055df82c4fb1c 0x000055df82c534f0 0x000055df9e63929d 0x000055dfa38f546e 0x000055df9141f61f 0x000055dfa32399d9 0x000055dfa327af4e 0x000055dfa32600d1 0x000055dfa325ea1c 0x000055dfa325e502 0x000055dfa3283c66 0x000055df90f03d1d 0x000055df90f0dbdf 0x000055df80930059 0x00007f0e0d64fac3 0x00007f0e0d6e1850
2024.09.02 11:58:02.792025 [ 1414 ] {} <Fatal> BaseDaemon: ########################################
2024.09.02 11:58:02.792149 [ 1414 ] {} <Fatal> BaseDaemon: (version 24.9.1.1600, build id: 8BE2A4CA9BB6DEF75A913D2354E944F21D73618B, git hash: f87bae407053e1d66480982191ea9c506e4302b5) (from thread 881) (query_id: 346f7792-f203-40b7-8a4b-4772c0e2a1d0) (query: SELECT DISTINCT concat(concat(concat(arrayZipUnaligned(materialize(['g', 'h', 'i'])), (1, 2, 3), 1, ('a', 'b', 'c')), arrayZipUnaligned(['a']), 2), (1, 'y')) FROM system.parts) Received signal Aborted (6)

@taiyang-li taiyang-li mentioned this pull request Sep 3, 2024
Closed
@taiyang-li
Copy link
Copy Markdown
Contributor Author

taiyang-li commented Sep 4, 2024 •
edited
Loading

failed ut not related to this pr https://s3.amazonaws.com/clickhouse-test-reports/69030/5832f982d681c9cce347f8c11f27dea029f6f359/performance_comparison__release__[4_4]/report.html

image

CurtizJ
CurtizJ reviewed Sep 4, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@CurtizJ CurtizJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general ok.

@taiyang-li
Copy link
Copy Markdown
Contributor Author

taiyang-li commented Sep 5, 2024

Failed performance test that is identical with last failure is not related to this pr

@CurtizJ CurtizJ added this pull request to the merge queue Sep 5, 2024
Merged via the queue into ClickHouse:master with commit 10d2631 Sep 5, 2024
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CurtizJ CurtizJ CurtizJ approved these changes

Assignees

@CurtizJ CurtizJ

Labels

pr-feature Pull request with new product feature pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@taiyang-li @robot-ch-test-poll1 @fm4v @CurtizJ @robot-ch-test-poll4 @robot-ch-test-poll3