Skip to content

[CI fest] Try to fix test_broken_projections/test.py::test_broken_ignored_replicated#66915

Merged
hanfei1991 merged 1 commit intoClickHouse:masterfrom
zvonand:zvonand-fix-66835
Jul 26, 2024
Merged

[CI fest] Try to fix test_broken_projections/test.py::test_broken_ignored_replicated#66915
hanfei1991 merged 1 commit intoClickHouse:masterfrom
zvonand:zvonand-fix-66835

Conversation

@zvonand
Copy link
Copy Markdown
Contributor

@zvonand zvonand commented Jul 23, 2024 •
edited by hanfei1991
Loading

Closes #66835

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@hanfei1991 hanfei1991 self-assigned this Jul 23, 2024
@hanfei1991 hanfei1991 added can be tested Allows running workflows for external contributors pr-not-for-changelog This PR should not be mentioned in the changelog labels Jul 23, 2024
@robot-clickhouse-ci-2
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-2 commented Jul 23, 2024 •
edited by robot-clickhouse
Loading

This is an automated comment for commit 8fb560d with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@zvonand
Copy link
Copy Markdown
Contributor Author

zvonand commented Jul 24, 2024

@hanfei1991 let's merge this as is and see if it fixes the flakiness in master

@hanfei1991 hanfei1991 changed the title Try to fix test_broken_projections/test.py::test_broken_ignored_replicated [CI fest] Try to fix test_broken_projections/test.py::test_broken_ignored_replicated Jul 24, 2024
@hanfei1991 hanfei1991 enabled auto-merge July 24, 2024 07:06
@hanfei1991 hanfei1991 added the 🍃 green ci 🌿 Fixing flaky tests in CI label Jul 24, 2024
@zvonand
Copy link
Copy Markdown
Contributor Author

zvonand commented Jul 26, 2024

@hanfei1991 looks like it does not want to merge automatically

@hanfei1991 hanfei1991 added this pull request to the merge queue Jul 26, 2024
Merged via the queue into ClickHouse:master with commit a9ceb0c Jul 26, 2024
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 26, 2024
@zvonand zvonand mentioned this pull request Jul 26, 2024
Merged
@zvonand zvonand deleted the zvonand-fix-66835 branch August 6, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hanfei1991 hanfei1991 hanfei1991 approved these changes

Assignees

@hanfei1991 hanfei1991

Labels

can be tested Allows running workflows for external contributors 🍃 green ci 🌿 Fixing flaky tests in CI pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test test_broken_projections/test.py::test_broken_ignored_replicated is flaky

4 participants

@zvonand @robot-clickhouse-ci-2 @hanfei1991 @robot-ch-test-poll4