Skip to content

Bump RocksDB from v6.29.5 to v7.10.2#66475

Merged
rschu1ze merged 4 commits intoClickHouse:masterfrom
rschu1ze:bump-rocksdb
Jul 31, 2024
Merged

Bump RocksDB from v6.29.5 to v7.10.2#66475
rschu1ze merged 4 commits intoClickHouse:masterfrom
rschu1ze:bump-rocksdb

Conversation

@rschu1ze
Copy link
Copy Markdown
Member

@rschu1ze rschu1ze commented Jul 13, 2024 •
edited
Loading

Continuation of #66216

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@robot-ch-test-poll1 robot-ch-test-poll1 added pr-not-for-changelog This PR should not be mentioned in the changelog submodule changed At least one submodule changed in this PR. labels Jul 13, 2024
@robot-ch-test-poll1
Copy link
Copy Markdown
Contributor

robot-ch-test-poll1 commented Jul 13, 2024 •
edited by robot-clickhouse-ci-2
Loading

This is an automated comment for commit 07507e0 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Unit testsRuns the unit tests for different release types❌ error
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@rschu1ze rschu1ze marked this pull request as ready for review July 13, 2024 16:44
@rschu1ze rschu1ze changed the title Bump rocksdb to v7 Bump rocksdb Jul 13, 2024
@alexey-milovidov alexey-milovidov self-assigned this Jul 13, 2024
@rschu1ze rschu1ze changed the title Bump rocksdb Bump RocksDB from v6.29.5 to v7.10.2 Jul 13, 2024
@rschu1ze rschu1ze mentioned this pull request Jul 15, 2024
Merged
@rschu1ze

This comment was marked as resolved.

Sign in to view
@rschu1ze rschu1ze added this pull request to the merge queue Jul 31, 2024
Merged via the queue into ClickHouse:master with commit 4b40e94 Jul 31, 2024
@rschu1ze rschu1ze deleted the bump-rocksdb branch July 31, 2024 09:49
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 31, 2024
@alexey-milovidov
Copy link
Copy Markdown
Member

alexey-milovidov commented Jul 31, 2024

@rschu1ze what was wrong with the unit tests here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@alexey-milovidov alexey-milovidov

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo submodule changed At least one submodule changed in this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rschu1ze @robot-ch-test-poll1 @alexey-milovidov @robot-clickhouse-ci-1