Skip to content

Remove flaky case from 02956_rocksdb_bulk_sink#66107

Merged
vdimir merged 10 commits intomasterfrom
vdimir/debug_02956_rocksdb_bulk_sink
Jul 16, 2024
Merged

Remove flaky case from 02956_rocksdb_bulk_sink#66107
vdimir merged 10 commits intomasterfrom
vdimir/debug_02956_rocksdb_bulk_sink

Conversation

@vdimir
Copy link
Copy Markdown
Member

@vdimir vdimir commented Jul 4, 2024

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

...

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@vdimir vdimir marked this pull request as draft July 4, 2024 18:30
@vdimir vdimir mentioned this pull request Jul 4, 2024
Merged
@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jul 4, 2024
@robot-ch-test-poll3
Copy link
Copy Markdown
Contributor

robot-ch-test-poll3 commented Jul 4, 2024 •
edited by robot-ch-test-poll
Loading

This is an automated comment for commit e3f58a8 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ error
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@vdimir vdimir changed the title Debuging 02956_rocksdb_bulk_sink Remove flaky case from 02956_rocksdb_bulk_sink Jul 8, 2024
@vdimir vdimir marked this pull request as ready for review July 8, 2024 10:36
@yariks5s yariks5s self-assigned this Jul 8, 2024
azat
azat reviewed Jul 8, 2024
View reviewed changes
tests/queries/0_stateless/02956_rocksdb_bulk_sink.sh
${CLICKHOUSE_CLIENT} --query "TRUNCATE TABLE rocksdb_worm;"
# Must set both max_threads and max_insert_threads to 2 to make sure there is only two sinks
${CLICKHOUSE_CLIENT} --query "INSERT INTO rocksdb_worm SELECT number, number+1 FROM numbers_mt(1000000) SETTINGS max_threads = 2, max_insert_threads = 2, max_block_size = 10000, min_insert_block_size_rows = 0, min_insert_block_size_bytes = 0, insert_deduplication_token = '', optimize_trivial_insert_select = 1;"
${CLICKHOUSE_CLIENT} --query "SELECT sum(value) FROM system.rocksdb WHERE database = currentDatabase() AND table = 'rocksdb_worm' AND name = 'no.file.opens';" # should be 2 because default bulk sink size is ~1M rows / SST file
Copy link
Copy Markdown
Member

@azat azat Jul 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe remove only the check for no.file.opens?

@alexey-milovidov alexey-milovidov mentioned this pull request Jul 11, 2024
Closed
@vdimir
Copy link
Copy Markdown
Member Author

vdimir commented Jul 11, 2024

Builds Pending — 13 of 21 builds are missing. 18/31 artifact groups are OK Details

@azat azat mentioned this pull request Jul 12, 2024
Closed
@alexey-milovidov
Copy link
Copy Markdown
Member

alexey-milovidov commented Jul 12, 2024

@vdimir tests have failed.

@azat azat mentioned this pull request Jul 14, 2024
Merged
@alexey-milovidov
Copy link
Copy Markdown
Member

alexey-milovidov commented Jul 14, 2024

Builds didn't even finish.

@vdimir vdimir added this pull request to the merge queue Jul 16, 2024
Merged via the queue into master with commit 5e18d38 Jul 16, 2024
@vdimir vdimir deleted the vdimir/debug_02956_rocksdb_bulk_sink branch July 16, 2024 10:47
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 16, 2024
@azat azat mentioned this pull request Aug 4, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@azat azat azat left review comments

@yariks5s yariks5s yariks5s approved these changes

Assignees

@yariks5s yariks5s

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vdimir @robot-ch-test-poll3 @alexey-milovidov @azat @yariks5s @robot-clickhouse