Skip to content

Avoid writing to finalized buffer in File-like storages#65063

Merged
Avogar merged 2 commits intoClickHouse:masterfrom
Avogar:avoid-write-to-finalized-buffer
Jun 17, 2024
Merged

Avoid writing to finalized buffer in File-like storages#65063
Avogar merged 2 commits intoClickHouse:masterfrom
Avogar:avoid-write-to-finalized-buffer

Conversation

@Avogar
Copy link
Copy Markdown
Member

@Avogar Avogar commented Jun 10, 2024 •
edited by Algunenano
Loading

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Avoid writing to finalized buffer in File-like storages

Closes #62962.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: Normal Builds
  • Allow: Special Builds
  • Allow: All NOT Required Checks
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Do not test
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-bugfix Pull request with bugfix, not backported by default label Jun 10, 2024
@robot-clickhouse-ci-2
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-2 commented Jun 10, 2024 •
edited by robot-ch-test-poll3
Loading

This is an automated comment for commit d9ff408 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
A SyncIf it fails, ask a maintainer for help❌ failure
Bugfix validationChecks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch❌ failure
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR❌ failure
Mergeable CheckChecks if all other necessary checks are successful❌ failure
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
PR CheckChecks correctness of the PR's body✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success

@kssenii kssenii self-assigned this Jun 10, 2024
kssenii
kssenii reviewed Jun 10, 2024
View reviewed changes
src/Storages/ObjectStorage/StorageObjectStorageSink.cpp Outdated
{
writer.reset();
write_buf.reset();
write_buf->finalize();
Copy link
Copy Markdown
Member

@kssenii kssenii Jun 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume finalize() was not called here on purpose 2c018f5#diff-a118e043f3175929dbe8a96c6dcc7db80e31ddae5581f29b4286eb9e2d9d925d

Copy link
Copy Markdown
Member Author

@Avogar Avogar Jun 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was confused because StorageFile and StorageURL had finalize() in the same place (and before StorageObject only StorageS3 didn't have finalize()). I am still not 100% sure that it's safe to just call .reset() here as we still can call finalize in destructor. Let me check the write buffers that could be used, maybe it's actually safe and we can use .reset() in all such places

Copy link
Copy Markdown
Member

@kssenii kssenii Jun 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and before StorageObject only StorageS3 didn't have finalize()

Yeah I also noticed that during refactoring (this finalize() was also there for StorageAzure) and changed it the same way, but it resulted in failing s3 tests

@Avogar Avogar force-pushed the avoid-write-to-finalized-buffer branch from 6e2d2c0 to d9ff408 Compare June 11, 2024 10:55
@Avogar Avogar requested a review from kssenii June 12, 2024 12:32
@Avogar Avogar added this pull request to the merge queue Jun 17, 2024
Merged via the queue into ClickHouse:master with commit bd4e76b Jun 17, 2024
@Avogar Avogar deleted the avoid-write-to-finalized-buffer branch June 17, 2024 12:46
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kssenii kssenii kssenii approved these changes

Assignees

@kssenii kssenii

Labels

pr-bugfix Pull request with bugfix, not backported by default pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ParquetBlockOutputFormat/ParquetBlockOutputFormat: Cannot write to finalized buffer

3 participants

@Avogar @robot-clickhouse-ci-2 @kssenii