Skip to content

Revert multiline pretty changes due to performance problems#63947

Merged
Algunenano merged 4 commits intoClickHouse:masterfrom
Algunenano:revert_multiline_pretty
May 17, 2024
Merged

Revert multiline pretty changes due to performance problems#63947
Algunenano merged 4 commits intoClickHouse:masterfrom
Algunenano:revert_multiline_pretty

Conversation

@Algunenano
Copy link
Copy Markdown
Member

@Algunenano Algunenano commented May 16, 2024

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

...

Performance tests were broken. It has become ~10x slower

Reverts:

cc @Volodyachan @yariks5s

Feel free to just revert this revert PR, fix the PR and resend.

Algunenano added 4 commits May 16, 2024 12:52
@Algunenano
Revert "Merge pull request ClickHouse#63783 from yariks5s/update_sett…
a2223f6 
…ings_history"

This reverts commit 1041af2, reversing
changes made to cd90655.
@Algunenano
Revert "Merge pull request ClickHouse#63493 from Volodyachan/fix-tabs…
610801f 
…-in-pretty-format"

This reverts commit 8ed2456, reversing
changes made to 7be88cc.
@Algunenano
Revert "Merge pull request ClickHouse#63479 from yariks5s/add_setting…
7e42948 
…_from_multiline_strings"

This reverts commit 962d5e5, reversing
changes made to 8c4a5d3.
@Algunenano
Revert "Merge pull request ClickHouse#59940 from Volodyachan/multilin…
7bcef97 
…e-strings-in-Pretty-formats"

This reverts commit e0c23fb, reversing
changes made to 02a5b01.
@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label May 16, 2024
@robot-clickhouse
Copy link
Copy Markdown
Member

robot-clickhouse commented May 16, 2024 •
edited by robot-ch-test-poll4
Loading

This is an automated comment for commit 7bcef97 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure
Successful checks
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@Algunenano Algunenano added this pull request to the merge queue May 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 17, 2024
@Algunenano Algunenano added this pull request to the merge queue May 17, 2024
Merged via the queue into ClickHouse:master with commit 68bff50 May 17, 2024
@Algunenano Algunenano deleted the revert_multiline_pretty branch May 17, 2024 10:26
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-synced-to-cloud The PR is synced to the cloud repo label May 17, 2024
@Volodyachan Volodyachan mentioned this pull request May 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Algunenano @robot-clickhouse @robot-clickhouse-ci-2