Skip to content

Verify formatting consistency on the server-side#60013

Merged
alexey-milovidov merged 3 commits intomasterfrom
verify-parser-on-server-side
Feb 16, 2024
Merged

Verify formatting consistency on the server-side#60013
alexey-milovidov merged 3 commits intomasterfrom
verify-parser-on-server-side

Conversation

@alexey-milovidov
Copy link
Copy Markdown
Member

@alexey-milovidov alexey-milovidov commented Feb 15, 2024

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

If it will work, we can remove it from the AST Fuzzer.

@robot-ch-test-poll robot-ch-test-poll added the pr-not-for-changelog This PR should not be mentioned in the changelog label Feb 15, 2024
@robot-ch-test-poll
Copy link
Copy Markdown
Contributor

robot-ch-test-poll commented Feb 15, 2024 •
edited
Loading

This is an automated comment for commit 00c28d9 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts❌ failure

@alexey-milovidov
Copy link
Copy Markdown
Member Author

alexey-milovidov commented Feb 16, 2024 •
edited
Loading

@Algunenano, FYI, it finds this instantly:

Logical error: 'Inconsistent AST formatting: the query:
SELECT COUNT(t0.c0) FROM t0 GROUP BY abs(abs(pow(lcm(t0.c0, t0.c0), -t0.c0))) HAVING (NOT '(OV풽0Un5' > abs('!#' IS NULL)) * COUNT(t0.c0) UNION ALL SELECT COUNT(t0.c0) FROM t0 GROUP BY abs(abs(pow(lcm(t0.c0, t0.c0), -t0.c0))) HAVING NOT ((NOT '(OV풽0Un5' > abs('!#' IS NULL)) *
Was parsed and formatted back as:
SELECT COUNT(t0.c0) FROM t0 GROUP BY abs(abs(pow(lcm(t0.c0, t0.c0), -t0.c0))) HAVING (NOT ('(OV풽0Un5' > abs('!#' IS NULL))) * COUNT(t0.c0) UNION ALL SELECT COUNT(t0.c0) FROM t0 GROUP BY abs(abs(pow(lcm(t0.c0, t0.c0), -t0.c0))) HAVING NOT ((NOT ('(OV풽0Un5' > abs('!#' IS NULL))

Requires #60042.

@Algunenano Algunenano self-assigned this Feb 16, 2024
@alexey-milovidov alexey-milovidov merged commit 25f2501 into master Feb 16, 2024
@alexey-milovidov alexey-milovidov deleted the verify-parser-on-server-side branch February 16, 2024 12:48
@robot-ch-test-poll robot-ch-test-poll added the pr-synced-to-cloud The PR is synced to the cloud repo label Feb 16, 2024
@antonio2368
Copy link
Copy Markdown
Member

antonio2368 commented Feb 19, 2024

This kills our CI because of invalid parsing
It was merged before debug tests finishing, I'll revert and this needs to be resubmitted with fixed tests.

@tavplubix tavplubix mentioned this pull request Feb 19, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Algunenano Algunenano Algunenano approved these changes

Assignees

@Algunenano Algunenano

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alexey-milovidov @robot-ch-test-poll @antonio2368 @Algunenano