Skip to content

Analyzer: Support GROUP BY injective function elimination#58919

Merged
novikd merged 5 commits intomasterfrom
analyzer-inj-func-elemination
Jan 26, 2024
Merged

Analyzer: Support GROUP BY injective function elimination#58919
novikd merged 5 commits intomasterfrom
analyzer-inj-func-elemination

Conversation

@novikd
Copy link
Copy Markdown
Member

@novikd novikd commented Jan 17, 2024

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Support GROUP BY injective function elimination.

@novikd novikd mentioned this pull request Jan 17, 2024
Closed
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jan 17, 2024
@robot-ch-test-poll1
Copy link
Copy Markdown
Contributor

robot-ch-test-poll1 commented Jan 17, 2024 •
edited by robot-clickhouse-ci-1
Loading

This is an automated comment for commit e9ea130 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker server and keeper imagesThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Docs checkThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Fast testsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Unit testsRuns the unit tests for different release types✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts❌ failure

@novikd novikd force-pushed the analyzer-inj-func-elemination branch from 3b34b62 to 773e5b0 Compare January 19, 2024 14:52
@novikd novikd marked this pull request as ready for review January 22, 2024 15:30
@qoega qoega added the analyzer Issues and pull-requests related to new analyzer label Jan 22, 2024
@vdimir vdimir self-assigned this Jan 22, 2024
@vdimir
Copy link
Copy Markdown
Member

vdimir commented Jan 22, 2024

CI:

Reused from [59049-4b4eac7c]

vdimir
vdimir reviewed Jan 22, 2024
View reviewed changes
@novikd
Copy link
Copy Markdown
Member Author

novikd commented Jan 23, 2024

@vdimir I addressed your comments and added tests.

@novikd novikd merged commit 6c5057c into master Jan 26, 2024
@novikd novikd deleted the analyzer-inj-func-elemination branch January 26, 2024 15:45
@Avogar
Copy link
Copy Markdown
Member

Avogar commented Jan 26, 2024 •
edited
Loading

Upgrade check (debug) New settings are not reflected in settings changes history (see new_settings.txt)

This failure is related and broke Upgrade check in other PRs, we should add new setting to SettingsChangesHistory

@Avogar Avogar mentioned this pull request Jan 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vdimir vdimir vdimir left review comments

Assignees

@vdimir vdimir

Labels

analyzer Issues and pull-requests related to new analyzer pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@novikd @robot-ch-test-poll1 @vdimir @Avogar @qoega