Skip to content

Allow parallel replicas for JOIN with analyzer [part 1].#58838

Merged
KochetovNicolai merged 4 commits intomasterfrom
allow-parallel-replicas-for-join-with-analyzer
Jan 18, 2024
Merged

Allow parallel replicas for JOIN with analyzer [part 1].#58838
KochetovNicolai merged 4 commits intomasterfrom
allow-parallel-replicas-for-join-with-analyzer

Conversation

@KochetovNicolai
Copy link
Copy Markdown
Member

@KochetovNicolai KochetovNicolai commented Jan 15, 2024

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fixes 02784_parallel_replicas_automatic_decision_join

@KochetovNicolai KochetovNicolai mentioned this pull request Jan 15, 2024
Closed
@KochetovNicolai KochetovNicolai added the analyzer Issues and pull-requests related to new analyzer label Jan 15, 2024
@robot-ch-test-poll robot-ch-test-poll added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jan 15, 2024
@robot-ch-test-poll
Copy link
Copy Markdown
Contributor

robot-ch-test-poll commented Jan 15, 2024 •
edited by robot-ch-test-poll3
Loading

This is an automated comment for commit b9a76e5 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests❌ failure

@novikd novikd self-assigned this Jan 15, 2024
Algunenano
Algunenano reviewed Jan 16, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Algunenano Algunenano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to remove allow_experimental_analyzer from 02731_parallel_replicas_join_subquery.sql to test it too.

And remove 2784_parallel_replicas_automatic_decision_join from analyzer_tech_debt.txt.

@KochetovNicolai KochetovNicolai merged commit 9db8b50 into master Jan 18, 2024
@KochetovNicolai KochetovNicolai deleted the allow-parallel-replicas-for-join-with-analyzer branch January 18, 2024 13:01
@Algunenano
Copy link
Copy Markdown
Member

Algunenano commented Jan 19, 2024

This broke 02901_parallel_replicas_rollup for the analyzer:

2024-01-17 03:23:55 [7bf12ce67677] 2024.01.17 10:23:54.648720 [ 4671 ] {02901_parallel_replicas_rollup-test_6rmivtmd} <Error> executeQuery: Code: 10. DB::Exception: Not found column max(_CAST(NULL_Nullable(UInt8), 'Nullable(UInt8)'_String)) in block. There are only columns: max(NULL_Nullable(UInt8)): While executing Remote. (NOT_FOUND_COLUMN_IN_BLOCK) (version 24.1.1.1150) (from [::1]:53230) (comment: 02901_parallel_replicas_rollup.sh) (in query:  SELECT 1 FROM nested GROUP BY 1 WITH ROLLUP ORDER BY max((SELECT 1 WHERE 0)); ), Stack trace (when copying this message, always include the lines below):
2024-01-17 03:23:55 
2024-01-17 03:23:55 0. ./build_docker/./src/Common/Exception.cpp:96: DB::Exception::Exception(DB::Exception::MessageMasked&&, int, bool) @ 0x000000000c7c329b in /usr/lib/debug/usr/bin/clickhouse.debug
2024-01-17 03:23:55 1. DB::Exception::Exception<String const&, String>(int, FormatStringHelperImpl<std::type_identity<String const&>::type, std::type_identity<String>::type>, String const&, String&&) @ 0x0000000007bd0327 in /usr/lib/debug/usr/bin/clickhouse.debug
2024-01-17 03:23:55 2. ./build_docker/./src/Core/Block.cpp:0: DB::Block::getByName(String const&, bool) const @ 0x000000001044028e in /usr/lib/debug/usr/bin/clickhouse.debug
2024-01-17 03:23:55 3. ./build_docker/./src/QueryPipeline/RemoteQueryExecutor.cpp:238: DB::adaptBlockStructure(DB::Block const&, DB::Block const&) @ 0x00000000106e542d in /usr/lib/debug/usr/bin/clickhouse.debug
2024-01-17 03:23:55 4. ./src/QueryPipeline/RemoteQueryExecutor.h:120: DB::RemoteQueryExecutor::processPacket(DB::Packet) @ 0x00000000106e37ca in /usr/lib/debug/usr/bin/clickhouse.debug
2024-01-17 03:23:55 5. ./build_docker/./src/QueryPipeline/RemoteQueryExecutor.cpp:413: DB::RemoteQueryExecutor::readAsync() @ 0x00000000106e4fa2 in /usr/lib/debug/usr/bin/clickhouse.debug
2024-01-17 03:23:55 6. ./src/QueryPipeline/RemoteQueryExecutor.h:135: DB::RemoteSource::tryGenerate() @ 0x0000000012b1a7af in /usr/lib/debug/usr/bin/clickhouse.debug
2024-01-17 03:23:55 7. ./contrib/llvm-project/libcxx/include/optional:344: DB::ISource::work() @ 0x00000000127d6fc3 in /usr/lib/debug/usr/bin/clickhouse.debug
2024-01-17 03:23:55 8. ./build_docker/./src/Processors/Executors/ExecutionThreadContext.cpp:0: DB::ExecutionThreadContext::executeTask() @ 0x00000000127eff7a in /usr/lib/debug/usr/bin/clickhouse.debug
2024-01-17 03:23:55 9. ./build_docker/./src/Processors/Executors/PipelineExecutor.cpp:273: DB::PipelineExecutor::executeStepImpl(unsigned long, std::atomic<bool>*) @ 0x00000000127e6990 in /usr/lib/debug/usr/bin/clickhouse.debug
2024-01-17 03:23:55 10. ./contrib/llvm-project/libcxx/include/__memory/shared_ptr.h:833: void std::__function::__policy_invoker<void ()>::__call_impl<std::__function::__default_alloc_func<DB::PipelineExecutor::spawnThreads()::$_0, void ()>>(std::__function::__policy_storage const*) @ 0x00000000127e7a78 in /usr/lib/debug/usr/bin/clickhouse.debug
2024-01-17 03:23:55 11. ./base/base/../base/wide_integer_impl.h:809: ThreadPoolImpl<ThreadFromGlobalPoolImpl<false>>::worker(std::__list_iterator<ThreadFromGlobalPoolImpl<false>, void*>) @ 0x000000000c8a93e1 in /usr/lib/debug/usr/bin/clickhouse.debug
2024-01-17 03:23:55 12. ./build_docker/./src/Common/ThreadPool.cpp:0: void std::__function::__policy_invoker<void ()>::__call_impl<std::__function::__default_alloc_func<ThreadFromGlobalPoolImpl<false>::ThreadFromGlobalPoolImpl<void ThreadPoolImpl<ThreadFromGlobalPoolImpl<false>>::scheduleImpl<void>(std::function<void ()>, Priority, std::optional<unsigned long>, bool)::'lambda0'()>(void&&)::'lambda'(), void ()>>(std::__function::__policy_storage const*) @ 0x000000000c8acc3c in /usr/lib/debug/usr/bin/clickhouse.debug
2024-01-17 03:23:55 13. ./base/base/../base/wide_integer_impl.h:809: void* std::__thread_proxy[abi:v15000]<std::tuple<std::unique_ptr<std::__thread_struct, std::default_delete<std::__thread_struct>>, void ThreadPoolImpl<std::thread>::scheduleImpl<void>(std::function<void ()>, Priority, std::optional<unsigned long>, bool)::'lambda0'()>>(void*) @ 0x000000000c8aba3e in /usr

@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jan 19, 2024
@tavplubix
Copy link
Copy Markdown
Member

tavplubix commented Jan 22, 2024

It was merged without waiting for CI to finish, let's revert

@tavplubix tavplubix mentioned this pull request Jan 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Algunenano Algunenano Algunenano left review comments

@novikd novikd novikd approved these changes

Assignees

@novikd novikd

Labels

analyzer Issues and pull-requests related to new analyzer pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@KochetovNicolai @robot-ch-test-poll @Algunenano @tavplubix @novikd @robot-clickhouse-ci-1