Skip to content

Kafka ZooKeeper#57625

Merged
antaljanosbenjamin merged 92 commits intomasterfrom
kafka-zookeeper
Aug 8, 2024
Merged

Kafka ZooKeeper#57625
antaljanosbenjamin merged 92 commits intomasterfrom
kafka-zookeeper

Conversation

@antaljanosbenjamin
Copy link
Copy Markdown
Member

@antaljanosbenjamin antaljanosbenjamin commented Dec 7, 2023 •
edited
Loading

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Add new experimental Kafka storage engine to store offsets in Keeper instead of relying on committing them to Kafka.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-feature Pull request with new product feature label Dec 7, 2023
@robot-clickhouse-ci-2
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-2 commented Dec 7, 2023 •
edited by robot-ch-test-poll
Loading

This is an automated comment for commit 92be2db with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@antaljanosbenjamin antaljanosbenjamin added the do not test disable testing on pull request label Dec 7, 2023
@kssenii kssenii self-assigned this May 8, 2024
kssenii
kssenii reviewed Aug 2, 2024
View reviewed changes
@antaljanosbenjamin
Copy link
Copy Markdown
Member Author

antaljanosbenjamin commented Aug 5, 2024

I will merge this PR once the tests pass, however there are things that should be addressed:

  1. Communicating the reason why restarting the table didn't work Kafka ZooKeeper #57625 (comment) . It is not expected to happen often, so it is fine for now.
  2. Make sure table recreation with same ZK path doesn't mess up the table, so saving the metadata of the table to ZK to make sure we deal with the exact same table (even if UUID matches, the topics might be different).
  3. Support direct read.
  4. Support system.kafka_consumers table

@antaljanosbenjamin antaljanosbenjamin added this pull request to the merge queue Aug 8, 2024
Merged via the queue into master with commit c9adfe2 Aug 8, 2024
@antaljanosbenjamin antaljanosbenjamin deleted the kafka-zookeeper branch August 8, 2024 14:40
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Aug 8, 2024
@antaljanosbenjamin antaljanosbenjamin mentioned this pull request Aug 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kssenii kssenii kssenii approved these changes

Assignees

@kssenii kssenii

Labels

pr-feature Pull request with new product feature pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@antaljanosbenjamin @robot-clickhouse-ci-2 @kssenii @robot-ch-test-poll1 @robot-clickhouse