Skip to content

Ignore finished ON CLUSTER tasks if hostname changed#57339

Merged
tavplubix merged 1 commit intomasterfrom
fix_ddlworker_hostname_change
Nov 29, 2023
Merged

Ignore finished ON CLUSTER tasks if hostname changed#57339
tavplubix merged 1 commit intomasterfrom
fix_ddlworker_hostname_change

Conversation

@tavplubix
Copy link
Copy Markdown
Member

@tavplubix tavplubix commented Nov 29, 2023 •
edited
Loading

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

In rare cases, ON CLUSTER queries queue could get stuck with Unexpected error, will try to restart main thread: Not found address of host error if the hostname of some host has changed. It's fixed. Fixes #39710

@tavplubix tavplubix mentioned this pull request Nov 29, 2023
Closed
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-bugfix Pull request with bugfix, not backported by default label Nov 29, 2023
@robot-ch-test-poll3
Copy link
Copy Markdown
Contributor

robot-ch-test-poll3 commented Nov 29, 2023 •
edited
Loading

This is an automated comment for commit 84abbaf with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
Bugfix validate checkChecks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch✅ success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure

@evillique evillique self-assigned this Nov 29, 2023
@tavplubix
Copy link
Copy Markdown
Member Author

tavplubix commented Nov 29, 2023

Stateless tests (msan) [5/6] - https://github.com/ClickHouse/ClickHouse/pull/56490/files#r1409556111
Stateless tests (release, s3 storage) [2/2] - #54748
Stress test (tsan) - #57367

@tavplubix tavplubix merged commit 97b63bb into master Nov 29, 2023
@tavplubix tavplubix deleted the fix_ddlworker_hostname_change branch November 29, 2023 16:46
@robot-clickhouse robot-clickhouse added the pr-backports-created-cloud deprecated label, NOOP label Nov 29, 2023
ashwath
ashwath reviewed Nov 29, 2023
View reviewed changes
src/Interpreters/DDLTask.cpp

if (!host_in_hostlist && first_exception)
{
String reason;
Copy link
Copy Markdown
Contributor

@ashwath ashwath Nov 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is reason used?

Copy link
Copy Markdown
Member Author

@tavplubix tavplubix Nov 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nowhere

@tavplubix tavplubix mentioned this pull request Nov 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evillique evillique evillique approved these changes

+1 more reviewer

@ashwath ashwath ashwath left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@evillique evillique

Labels

pr-backports-created-cloud deprecated label, NOOP pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

If some of the hosts are not resolving, DDLWorker can still process the queue entries for our own host.

5 participants

@tavplubix @robot-ch-test-poll3 @ashwath @evillique @robot-clickhouse