Skip to content

Fix race condition between DROP_RANGE and committing existing block#56083

Merged
tavplubix merged 2 commits intomasterfrom
fix_drop_range_commit_existing_part_race
Oct 31, 2023
Merged

Fix race condition between DROP_RANGE and committing existing block#56083
tavplubix merged 2 commits intomasterfrom
fix_drop_range_commit_existing_part_race

Conversation

@tavplubix
Copy link
Copy Markdown
Member

@tavplubix tavplubix commented Oct 27, 2023

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Fixes #56037

@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Oct 27, 2023
@robot-ch-test-poll1
Copy link
Copy Markdown
Contributor

robot-ch-test-poll1 commented Oct 27, 2023 •
edited by robot-clickhouse-ci-2
Loading

This is an automated comment for commit ae8d7a5 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure

@Algunenano Algunenano self-assigned this Oct 27, 2023
alexey-milovidov
alexey-milovidov approved these changes Oct 27, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@alexey-milovidov alexey-milovidov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Interesting if writing a test that could reproduce it even occasionally will be possible.

@alexey-milovidov alexey-milovidov self-assigned this Oct 27, 2023
Algunenano
Algunenano reviewed Oct 30, 2023
View reviewed changes
src/Storages/MergeTree/ReplicatedMergeTreeSink.cpp
storage.checkPartChecksumsAndAddCommitOps(zookeeper, part, ops, existing_part_name, unused);

/// We have to check that the block_id still exists to avoid a race condition with DROP_RANGE
block_unlock_op_idx = ops.size();
Copy link
Copy Markdown
Member

@Algunenano Algunenano Oct 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that we should update the exception message in:

        else if (multi_code == Coordination::Error::ZNONODE && zkutil::getFailedOpIndex(multi_code, responses) == block_unlock_op_idx)
        {
            throw Exception(ErrorCodes::QUERY_WAS_CANCELLED,
                            "Insert query (for block {}) was cancelled by concurrent ALTER PARTITION", block_number_lock->getPath());
        }

And instead of ALTER PARTITION it should say "operation" or something more generic, right?

Copy link
Copy Markdown
Member Author

@tavplubix tavplubix Oct 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And instead of ALTER PARTITION it should say "operation" or something more generic, right?

It can be canceled by ALTER PARTITION or TRUNCATE (which is basically DROP PARTITION for all partitions). But a part can be removed from zk as a result of a merge, for example. And looks like in rare cases it may trigger this message too after my changes

@tavplubix
Copy link
Copy Markdown
Member Author

tavplubix commented Oct 31, 2023

Integration tests (asan) [1/6] - docker issue
Integration tests (asan, analyzer) [1/6] - docker issue
Integration tests (release) [4/4] - #54502

@tavplubix tavplubix merged commit f39f0c6 into master Oct 31, 2023
@tavplubix tavplubix deleted the fix_drop_range_commit_existing_part_race branch October 31, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Algunenano Algunenano Algunenano approved these changes

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@Algunenano Algunenano

@alexey-milovidov alexey-milovidov

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

LOGICAL_ERROR: Part {} remains in ZooKeeper after DROP_RANGE {}

4 participants

@tavplubix @robot-ch-test-poll1 @Algunenano @alexey-milovidov