Mutations having deleted table in subquery don't retry indefinitely#55946
Closed
myrrc wants to merge 6 commits intoClickHouse:masterfrom
myrrc:fix/mutation-for-deleted-subtable
Closed
Mutations having deleted table in subquery don't retry indefinitely#55946myrrc wants to merge 6 commits intoClickHouse:masterfrom myrrc:fix/mutation-for-deleted-subtable
myrrc wants to merge 6 commits intoClickHouse:masterfrom
myrrc:fix/mutation-for-deleted-subtable
Conversation
Contributor
|
This is an automated comment for commit 37f2fb2 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
added 2 commits
October 24, 2023 12:24
Contributor
Author
|
This PR has multiple flaws I'd like to address
A good solution could manage an exponential backoff for failed mutations, but we have only start time (not finish time) in system.mutations, and time is not used while planning the mutation job to MergeTreeBackgroundExecutor |
added 2 commits
October 24, 2023 13:52
Contributor
Author
|
As Mikhail is working on a better approach for mutations, closing this PR |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Mutations having deleted table in subquery don't retry indefinitely and fail fast.
Resolves #37435
Related: #36987