Skip to content

Fix AST fuzzer crash in MergeTreeIndex{FullText|Inverted}#54563

Merged
rschu1ze merged 3 commits intoClickHouse:masterfrom
rschu1ze:issue-54541
Sep 13, 2023
Merged

Fix AST fuzzer crash in MergeTreeIndex{FullText|Inverted}#54563
rschu1ze merged 3 commits intoClickHouse:masterfrom
rschu1ze:issue-54541

Conversation

@rschu1ze
Copy link
Copy Markdown
Member

@rschu1ze rschu1ze commented Sep 12, 2023

Fixes #54541

The check / LOGICAL_ERROR only exists in debug builds, official builds are not affected --> "Not for changelog".

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@rschu1ze rschu1ze changed the title Fix AST fuzzer crash in Fix AST fuzzer crash in MergeTreeIndexFullText Sep 12, 2023
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added pr-not-for-changelog This PR should not be mentioned in the changelog pr-status-⏳ labels Sep 12, 2023
@robot-clickhouse-ci-2
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-2 commented Sep 12, 2023 •
edited by robot-ch-test-poll1
Loading

This is an automated comment for commit 8c7a256 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure

@rschu1ze rschu1ze changed the title Fix AST fuzzer crash in MergeTreeIndexFullText Fix AST fuzzer crash in MergeTreeIndex{FullText|Inverted} Sep 12, 2023
@yakov-olkhovskiy yakov-olkhovskiy self-assigned this Sep 13, 2023
yakov-olkhovskiy
yakov-olkhovskiy reviewed Sep 13, 2023
View reviewed changes
src/Storages/MergeTree/MergeTreeIndexFullText.cpp

if (const_value.getType() == Field::Types::Float64)
{
out.function = const_value.get<Float64>() != 0.0 ? RPNElement::ALWAYS_TRUE : RPNElement::ALWAYS_FALSE;
Copy link
Copy Markdown
Member

@yakov-olkhovskiy yakov-olkhovskiy Sep 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to check if float equal to zero or if all bits are zeroes? please notice that float can be -0 in which case sign bit is 1...

Copy link
Copy Markdown
Member Author

@rschu1ze rschu1ze Sep 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comparison was stolen from other code parts which do the same.

But you are right. If possible, allow me to make another PR because such changes may have some fallout.

@rschu1ze rschu1ze merged commit 59cded9 into ClickHouse:master Sep 13, 2023
@azat azat mentioned this pull request Sep 20, 2023
Merged
@rschu1ze rschu1ze mentioned this pull request Nov 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yakov-olkhovskiy yakov-olkhovskiy yakov-olkhovskiy approved these changes

Assignees

@yakov-olkhovskiy yakov-olkhovskiy

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AST Fuzzer crash in MergeTreeConditionFullText::MergeTreeConditionFullText

5 participants

@rschu1ze @robot-clickhouse-ci-2 @yakov-olkhovskiy @robot-ch-test-poll @robot-clickhouse-ci-1