Skip to content

Follow-up to #53501#53851

Merged
tavplubix merged 2 commits intomasterfrom
distributed_no_flush_on_shutdown
Aug 29, 2023
Merged

Follow-up to #53501#53851
tavplubix merged 2 commits intomasterfrom
distributed_no_flush_on_shutdown

Conversation

@tavplubix
Copy link
Copy Markdown
Member

@tavplubix tavplubix commented Aug 25, 2023 •
edited
Loading

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Follow-up to #53501

It still was waiting for flush in ~DistributedAsyncInsertDirectoryQueue(), avoid this
Fixes #53408

@tavplubix tavplubix changed the title Follow-up to https://github.com/ClickHouse/ClickHouse/pull/53501 Follow-up to #53501 Aug 25, 2023
@tavplubix tavplubix requested a review from azat August 25, 2023 17:10
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Aug 25, 2023
@robot-ch-test-poll3
Copy link
Copy Markdown
Contributor

robot-ch-test-poll3 commented Aug 25, 2023 •
edited by robot-clickhouse-ci-2
Loading

This is an automated comment for commit d41eca1 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🔴 failure
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟡 pending
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🟢 success
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🔴 failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success

@tavplubix tavplubix mentioned this pull request Aug 25, 2023
Closed
azat
azat reviewed Aug 27, 2023
View reviewed changes
src/Storages/Distributed/DistributedAsyncInsertDirectoryQueue.cpp
void DistributedAsyncInsertDirectoryQueue::shutdown()
{
/// It's incompatible with should_batch_inserts
/// because processFilesWithBatching may push to the queue after shutdown
Copy link
Copy Markdown
Member

@azat azat Aug 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it should not be a problem, since this queue is only in memory and it can be finished (which will break push) only in case of shutdown, so we can simply log this error and continue.

Copy link
Copy Markdown
Member Author

@tavplubix tavplubix Aug 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean that it may trigger a logical error:

ClickHouse/src/Storages/Distributed/DistributedAsyncInsertDirectoryQueue.cpp

Lines 661 to 662 in 9ab545e

if (!pending_files.pushFront(file))
throw Exception(ErrorCodes::LOGICAL_ERROR, "Cannot re-schedule a file '{}'", file);

Copy link
Copy Markdown
Member

@azat azat Aug 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, and I was suggesting to replace this LOGICAL_ERROR with LOG_WARNING or smth

src/Storages/Distributed/DistributedAsyncInsertDirectoryQueue.h Outdated

void shutdownAndDropAllData();

void shutdown();
Copy link
Copy Markdown
Member

@azat azat Aug 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe rename it to stop or similar, or shutdownWithoutFlush?

@tavplubix
Copy link
Copy Markdown
Member Author

tavplubix commented Aug 28, 2023

Upgrade check (tsan) - #52540

@tavplubix
Copy link
Copy Markdown
Member Author

tavplubix commented Aug 29, 2023

AST fuzzer is broken because of sending logs from CI to the cloud
Stateless tests (debug, s3 storage) [1/6] - #53309 (comment)

@tavplubix tavplubix merged commit 17f3754 into master Aug 29, 2023
@tavplubix tavplubix deleted the distributed_no_flush_on_shutdown branch August 29, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@azat azat azat left review comments

Assignees

No one assigned

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Possible deadlock on shutdown of StorageDistributed

3 participants

@tavplubix @robot-ch-test-poll3 @azat