Skip to content

bugfix: Flush async insert queue first on shutdown#53547

Merged
CurtizJ merged 3 commits intoClickHouse:masterfrom
joelynch:shutdown-async-insert-queue-first
Aug 24, 2023
Merged

bugfix: Flush async insert queue first on shutdown#53547
CurtizJ merged 3 commits intoClickHouse:masterfrom
joelynch:shutdown-async-insert-queue-first

Conversation

@joelynch
Copy link
Copy Markdown
Contributor

@joelynch joelynch commented Aug 18, 2023

Fixes bug where on graceful shutdown the database catalog is shutdown before queries in the async insert queue run, causing all the queries to fail and data to be lost.

Can easily recreate by running

CREATE TABLE test (a String, b UInt64) ENGINE = MergeTree ORDER BY a;
SET async_insert = 1;
SET wait_for_async_insert = 0;
SET async_insert_busy_timeout_ms = 1000000;
INSERT INTO test VALUES ('world', 23456);

then shutting down the server. Expected behaviour: when ClickHouse is restarted, table test has 1 row. Actual behaviour: Clickhouse logs an ERROR and when restarted table test has 0 rows.

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix bug in flushing of async insert queue on graceful shutdown.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Aug 18, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@joelynch joelynch changed the title Flush async insert queue first on shutdown bugfix: Flush async insert queue first on shutdown Aug 18, 2023
@alexey-milovidov alexey-milovidov added the can be tested Allows running workflows for external contributors label Aug 18, 2023
@robot-ch-test-poll robot-ch-test-poll added the pr-bugfix Pull request with bugfix, not backported by default label Aug 18, 2023
@robot-ch-test-poll
Copy link
Copy Markdown
Contributor

robot-ch-test-poll commented Aug 18, 2023 •
edited by robot-ch-test-poll2
Loading

This is an automated comment for commit 075c026 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
Bugfix validate checkChecks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch🟢 success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟢 success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🔴 failure
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🔴 failure

@CurtizJ CurtizJ self-assigned this Aug 19, 2023
@joelynch
Copy link
Copy Markdown
Contributor Author

joelynch commented Aug 21, 2023

Added a test

@joelynch joelynch force-pushed the shutdown-async-insert-queue-first branch from 2c14834 to 7eef0bd Compare August 21, 2023 10:59
@joelynch
Copy link
Copy Markdown
Contributor Author

joelynch commented Aug 21, 2023

Some errors in CI but seem unrelated to this change

@joelynch joelynch force-pushed the shutdown-async-insert-queue-first branch from 7eef0bd to b24d166 Compare August 22, 2023 07:20
@joelynch
Flush async insert queue first on shutdown
192c3dd 
Fixes bug where on graceful shutdown the database catalog is shutdown
before queries in the async insert queue run, causing all the
queries to fail and data to be lost.
@joelynch
Add test for flushing async insert queue
8d0824f
@joelynch
These queries need to be run in the same session
075c026
@joelynch joelynch force-pushed the shutdown-async-insert-queue-first branch from b24d166 to 075c026 Compare August 23, 2023 13:00
@CurtizJ
Copy link
Copy Markdown
Member

CurtizJ commented Aug 24, 2023

test_merge_tree_azure_blob_storage/test.py::test_table_manipulations is flaky.

test_storage_rabbitmq is unrelated.

@CurtizJ CurtizJ merged commit 19a52f1 into ClickHouse:master Aug 24, 2023
@joelynch joelynch deleted the shutdown-async-insert-queue-first branch September 1, 2023 17:29
@tavplubix tavplubix mentioned this pull request Jan 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CurtizJ CurtizJ CurtizJ approved these changes

Assignees

@CurtizJ CurtizJ

Labels

can be tested Allows running workflows for external contributors pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@joelynch @CLAassistant @robot-ch-test-poll @CurtizJ @alexey-milovidov