Skip to content

Fix for analyzer: 02377_ optimize_sorting_by_input_stream_properties_e…#49943

Merged
devcrafter merged 2 commits intomasterfrom
test-sorting-stream-properties-analyzer
May 20, 2023
Merged

Fix for analyzer: 02377_ optimize_sorting_by_input_stream_properties_e…#49943
devcrafter merged 2 commits intomasterfrom
test-sorting-stream-properties-analyzer

Conversation

@devcrafter
Copy link
Copy Markdown
Member

@devcrafter devcrafter commented May 17, 2023

Run queries which output contains column identifiers twice with and without analyzer enabled.

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@devcrafter devcrafter mentioned this pull request May 17, 2023
Closed
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label May 17, 2023
@robot-clickhouse-ci-1
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-1 commented May 17, 2023 •
edited by robot-ch-test-poll1
Loading

This is an automated comment for commit c68a25a with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟢 success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🟢 success
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🔴 failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success

@nickitat nickitat self-assigned this May 17, 2023
nickitat
nickitat reviewed May 17, 2023
View reviewed changes
tests/queries/0_stateless/02377_optimize_sorting_by_input_stream_properties_explain.reference
Sorting (None)
Sorting (Sorting for ORDER BY)
Sorting (Global): plus(a_0, 1_UInt8) ASC
Sorting (Global): plus(default.optimize_sorting.a_3, 1_UInt8) ASC
Copy link
Copy Markdown
Member

@nickitat nickitat May 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it ok that they're different?

Copy link
Copy Markdown
Member Author

@devcrafter devcrafter May 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, Sorting (Global): plus(a_0, 1_UInt8) ASC is ORDER BY output and plus(a_0, 1_UInt8) UInt64 is the sorting column

@novikd novikd self-assigned this May 18, 2023
@devcrafter devcrafter merged commit 148742c into master May 20, 2023
@devcrafter devcrafter deleted the test-sorting-stream-properties-analyzer branch May 20, 2023 09:14
@devcrafter devcrafter mentioned this pull request May 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickitat nickitat nickitat left review comments

@novikd novikd novikd approved these changes

Assignees

@nickitat nickitat

@novikd novikd

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@devcrafter @robot-clickhouse-ci-1 @nickitat @novikd