Fix 00597_push_down_predicate_long for analyzer#49551
Merged
devcrafter merged 5 commits intomasterfrom May 7, 2023
Merged
Conversation
00597_push_down_predicate_long
Contributor
|
This is an automated comment for commit fd073f1 with description of existing statuses. It's updated for the latest CI running
|
devcrafter
commented
May 5, 2023
tests/queries/0_stateless/00597_push_down_predicate_long.reference
Outdated
Show resolved
Hide resolved
novikd
reviewed
May 5, 2023
Member
novikd
left a comment
There was a problem hiding this comment.
I'd rather prefer repeating queries with different values of the allow_experimental_analyzer setting than explicitly writing the meaning of *.
novikd
approved these changes
May 5, 2023
Member
Author
|
Stateless Tests (release, S3 Storage) fails - #49552 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The difference is only in column order in projection.
From observation, queries like
select * from left ANY LEFT JOIN right USING idproduce the same result, but with different column order in projection.
Current behavior: first columns from
lefttable, then columns fromrighttable.New analyzer: columns from
USING, rest columns fromleft, rest columns fromright00597_push_down_predicate_longis adjusted by duplicating queries with explicitly setallow_experimental analyzerRelated to #42648
Changelog category (leave one):