Skip to content

Correctly stop CNF convert for too many atomics in new analyzer#49402

Merged
antonio2368 merged 10 commits intomasterfrom
fix-cnf-new-analyzer
May 10, 2023
Merged

Correctly stop CNF convert for too many atomics in new analyzer#49402
antonio2368 merged 10 commits intomasterfrom
fix-cnf-new-analyzer

Conversation

@antonio2368
Copy link
Copy Markdown
Member

@antonio2368 antonio2368 commented May 2, 2023

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

cc @novikd

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@antonio2368 antonio2368 mentioned this pull request May 2, 2023
Closed
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-not-for-changelog This PR should not be mentioned in the changelog label May 2, 2023
@robot-ch-test-poll3
Copy link
Copy Markdown
Contributor

robot-ch-test-poll3 commented May 2, 2023 •
edited by robot-clickhouse-ci-2
Loading

This is an automated comment for commit c690480 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🟡 pending

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟡 pending
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success

@novikd novikd self-assigned this May 2, 2023
@antonio2368 antonio2368 requested a review from novikd May 8, 2023 06:18
novikd
novikd approved these changes May 9, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@novikd novikd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antonio2368 antonio2368 merged commit 8509f1b into master May 10, 2023
@antonio2368 antonio2368 deleted the fix-cnf-new-analyzer branch May 10, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@novikd novikd novikd approved these changes

Assignees

@novikd novikd

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@antonio2368 @robot-ch-test-poll3 @novikd @robot-clickhouse