Skip to content

Fix IN with decimal in analyzer#48754

Merged
vdimir merged 6 commits intomasterfrom
vdimir/decimal_in_precision_analyzer
Aug 8, 2023
Merged

Fix IN with decimal in analyzer#48754
vdimir merged 6 commits intomasterfrom
vdimir/decimal_in_precision_analyzer

Conversation

@vdimir
Copy link
Copy Markdown
Member

@vdimir vdimir commented Apr 13, 2023 •
edited
Loading

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

...

@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Apr 13, 2023
@vdimir vdimir force-pushed the vdimir/decimal_in_precision_analyzer branch from cc27790 to 02d57a2 Compare April 14, 2023 10:41
@vdimir vdimir mentioned this pull request Apr 17, 2023
Merged
1 task
@vdimir vdimir force-pushed the vdimir/decimal_in_precision_analyzer branch from e4e0ed9 to 0c3496c Compare April 18, 2023 16:24
novikd
novikd reviewed Apr 18, 2023
View reviewed changes
@novikd novikd self-assigned this Apr 18, 2023
@novikd
Copy link
Copy Markdown
Member

novikd commented Apr 21, 2023

Build failed

Apr 18 21:57:48 /build/src/Analyzer/SetUtils.cpp:80:36: error: passing result of std::move() as a const reference argument; no move will actually happen [performance-move-const-arg,-warnings-as-errors]
Apr 18 21:57:48                 columns[0]->insert(std::move(field));
Apr 18 21:57:48                                    ^~~~~~~~~~     ~
Apr 18 21:57:48 16202 warnings generated.
Apr 18 21:57:48 Suppressed 16654 warnings (16201 in non-user code, 453 NOLINT).
Apr 18 21:57:48 Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
Apr 18 21:57:48 1 warning treated as error

@vdimir vdimir force-pushed the vdimir/decimal_in_precision_analyzer branch from 0c3496c to bc07474 Compare May 4, 2023 14:26
@robot-ch-test-poll
Copy link
Copy Markdown
Contributor

robot-ch-test-poll commented May 4, 2023 •
edited by robot-clickhouse-ci-2
Loading

This is an automated comment for commit 1142180 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟢 success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🟢 success
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🔴 failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success

@vdimir vdimir force-pushed the vdimir/decimal_in_precision_analyzer branch 4 times, most recently from 37fa378 to 670f934 Compare May 5, 2023 09:52
@vdimir vdimir force-pushed the vdimir/decimal_in_precision_analyzer branch from 670f934 to c72eca7 Compare August 3, 2023 15:16
@vdimir vdimir force-pushed the vdimir/decimal_in_precision_analyzer branch from c72eca7 to 1142180 Compare August 4, 2023 10:09
@vdimir vdimir requested a review from novikd August 7, 2023 13:41
@vdimir vdimir mentioned this pull request Aug 7, 2023
Closed
@vdimir vdimir merged commit 3131358 into master Aug 8, 2023
@vdimir vdimir deleted the vdimir/decimal_in_precision_analyzer branch August 8, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@novikd novikd novikd approved these changes

Assignees

@novikd novikd

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vdimir @novikd @robot-ch-test-poll @robot-ch-test-poll4