Skip to content

Analyzer Planner enable by default#45461

Closed
kitaisreal wants to merge 1 commit intoClickHouse:masterfrom
kitaisreal:analyzer-planner-enable-by-default
Closed

Analyzer Planner enable by default#45461
kitaisreal wants to merge 1 commit intoClickHouse:masterfrom
kitaisreal:analyzer-planner-enable-by-default

Conversation

@kitaisreal
Copy link
Copy Markdown
Contributor

@kitaisreal kitaisreal commented Jan 20, 2023

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@kitaisreal kitaisreal added the can be tested Allows running workflows for external contributors label Jan 20, 2023
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jan 20, 2023
@kitaisreal kitaisreal force-pushed the analyzer-planner-enable-by-default branch 10 times, most recently from 9020e53 to cdd2c0e Compare January 23, 2023 21:35
@kitaisreal kitaisreal force-pushed the analyzer-planner-enable-by-default branch from cdd2c0e to 798d7b8 Compare January 24, 2023 09:04
@qoega qoega mentioned this pull request Jan 24, 2023
Closed
@kitaisreal kitaisreal force-pushed the analyzer-planner-enable-by-default branch 3 times, most recently from 93a932c to ac97e1a Compare January 24, 2023 16:38
@robot-ch-test-poll4 robot-ch-test-poll4 added the submodule changed At least one submodule changed in this PR. label Jan 24, 2023
@kitaisreal kitaisreal force-pushed the analyzer-planner-enable-by-default branch from ac97e1a to d171ea6 Compare January 24, 2023 18:20
@kitaisreal kitaisreal removed the submodule changed At least one submodule changed in this PR. label Jan 24, 2023
@kitaisreal kitaisreal mentioned this pull request Jan 24, 2023
Merged
@kitaisreal kitaisreal force-pushed the analyzer-planner-enable-by-default branch 8 times, most recently from 4c1a25c to 6d800c2 Compare January 29, 2023 12:39
@kitaisreal kitaisreal mentioned this pull request Feb 14, 2023
Merged
1 task
@kitaisreal kitaisreal force-pushed the analyzer-planner-enable-by-default branch 13 times, most recently from 53b3574 to 276ae35 Compare February 20, 2023 20:50
@kitaisreal kitaisreal force-pushed the analyzer-planner-enable-by-default branch 2 times, most recently from c7f4e8c to d39f375 Compare February 21, 2023 21:16
@jrdi
Copy link
Copy Markdown
Contributor

jrdi commented Feb 22, 2023 •
edited
Loading

We've started to run this branch in our CI environment, first error that it's raising is that queries to system.zookeeper are failing as follows:

SELECT *
FROM system.zookeeper
WHERE path = 'path'

Query id: 24da186e-f8ab-437f-822e-40430cc2f3ae


0 rows in set. Elapsed: 0.187 sec.

Received exception from server (version 23.2.1):
Code: 36. DB::Exception: Received from localhost:9000. DB::Exception: SELECT from system.zookeeper table must contain condition like path = 'path' or path IN ('path1','path2'...) or path IN (subquery) in WHERE clause unless `set allow_unrestricted_reads_from_keeper = 'true'`.. (BAD_ARGUMENTS)

When deactivating the analyzer everything works fine:

SELECT *
FROM system.zookeeper
WHERE path = 'path'
SETTINGS allow_experimental_analyzer = 0

Query id: 38167da5-23f8-4cd5-8be6-55a2b71fbfc1

Ok.

0 rows in set. Elapsed: 0.002 sec.

@kitaisreal kitaisreal force-pushed the analyzer-planner-enable-by-default branch 3 times, most recently from f339b71 to 87c2fe7 Compare February 23, 2023 15:26
@devcrafter devcrafter mentioned this pull request Feb 28, 2023
Merged
@vdimir vdimir mentioned this pull request Mar 1, 2023
Merged
@Algunenano Algunenano mentioned this pull request Mar 3, 2023
Merged
@KochetovNicolai KochetovNicolai mentioned this pull request Mar 3, 2023
Closed
@vdimir vdimir mentioned this pull request Mar 7, 2023
Merged
3 tasks
@robot-clickhouse-ci-1
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-1 commented May 6, 2023 •
edited by robot-ch-test-poll2
Loading

This is an automated comment for commit e18fd1f with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Check nameDescriptionStatus
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here❌ failure
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc❌ failure
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Mergeable CheckChecks if all other necessary checks are successful❌ failure
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests❌ failure
SQLancerFuzzing tests that detect logical bugs with SQLancer tool❌ failure
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts❌ failure

@kitaisreal kitaisreal mentioned this pull request Nov 9, 2023
Merged
@alexey-milovidov
Copy link
Copy Markdown
Member

alexey-milovidov commented Apr 23, 2024

We did it.

@handgunman
Copy link
Copy Markdown
Contributor

handgunman commented Apr 29, 2024

There's a problem with the analyzer:
https://fiddle.clickhouse.com/268bdedc-33d9-43ea-b78a-68957a9a709e
#62820

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@novikd novikd

Labels

can be tested Allows running workflows for external contributors pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@kitaisreal @jrdi @robot-clickhouse-ci-1 @alexey-milovidov @handgunman @novikd @robot-ch-test-poll4 @robot-clickhouse-ci-2