Skip to content

Fix ConcurrentBoundedQueue::emplace() return value in case of finished queue#44881

Merged
kitaisreal merged 1 commit intoClickHouse:masterfrom
azat:concurrent-bounded-queue-fix
Jan 4, 2023
Merged

Fix ConcurrentBoundedQueue::emplace() return value in case of finished queue#44881
kitaisreal merged 1 commit intoClickHouse:masterfrom
azat:concurrent-bounded-queue-fix

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Jan 3, 2023

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Cc: @kitaisreal

@azat
Fix ConcurrentBoundedQueue::emplace() return value in case of finishe…
a2f17d2 
…d queue

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
@azat azat force-pushed the concurrent-bounded-queue-fix branch from 3ccbfcd to a2f17d2 Compare January 3, 2023 19:36
@azat azat changed the title Fix ConcurrentBoundedQueue::emplace() retur nvalue in case of finished queue Fix ConcurrentBoundedQueue::emplace() return value in case of finished queue Jan 3, 2023
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jan 3, 2023
@azat azat mentioned this pull request Jan 3, 2023
Merged
@kitaisreal kitaisreal self-assigned this Jan 3, 2023
@azat
Copy link
Copy Markdown
Member Author

azat commented Jan 4, 2023

Performance Comparison [1/4] — Errors while building the report.

Performance tests are broken, and errors is not detected (looks like should be fixed by #44867)

@Felixoid
Copy link
Copy Markdown
Member

Felixoid commented Jan 4, 2023

The tests themself are supposed to be fixed in #44876

@azat
Copy link
Copy Markdown
Member Author

azat commented Jan 4, 2023 •
edited
Loading

The tests themself are supposed to be fixed in #44876

@Felixoid thank you! Funny, I haven't found it, because of the typo in the subject.

@kitaisreal kitaisreal merged commit 2482acc into ClickHouse:master Jan 4, 2023
@antonio2368
Copy link
Copy Markdown
Member

antonio2368 commented Jan 4, 2023

@azat test_keeper_snapshot_on_exit/test.py::test_snapshot_on_exit failure seems to be related to this

@antonio2368 antonio2368 mentioned this pull request Jan 4, 2023
Merged
@azat azat deleted the concurrent-bounded-queue-fix branch January 18, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kitaisreal kitaisreal kitaisreal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kitaisreal kitaisreal

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@azat @Felixoid @antonio2368 @kitaisreal @robot-clickhouse-ci-2