Skip to content

Introduce groupArrayLast() (useful to store last X values)#44521

Merged
nickitat merged 3 commits intoClickHouse:masterfrom
azat:groupArrayLast
Jan 2, 2023
Merged

Introduce groupArrayLast() (useful to store last X values)#44521
nickitat merged 3 commits intoClickHouse:masterfrom
azat:groupArrayLast

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Dec 22, 2022

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Introduce groupArrayLast() (useful to store last X values)

@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Dec 22, 2022
@azat azat mentioned this pull request Dec 22, 2022
Merged
@nickitat nickitat self-assigned this Dec 23, 2022
@azat
Copy link
Copy Markdown
Member Author

azat commented Dec 23, 2022

Conflicting files
src/AggregateFunctions/AggregateFunctionGroupArray.h

Rebased

AST fuzzer (asan) — Received signal 11

Fixed (typo in the coditions for merge)

nickitat
nickitat reviewed Dec 23, 2022
View reviewed changes
azat added 3 commits December 26, 2022 13:21
@azat
Cleanup DataTypeCustomSimpleAggregateFunction::checkSupportedFunctions()
3ddf7ab 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
@azat
Remove unused GroupArrayGeneralListImpl
f03899f 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
@azat
Introduce groupArrayLast() (useful to store last X values)
fb42fcb 
Also do some refactoring to make code cleaner:
- rename insert() to insertWithSampler() (since it is used only for
  groupArraySample())
- split merge methods into Last/RNG/...

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
@azat azat requested a review from nickitat December 27, 2022 11:19
@azat
Copy link
Copy Markdown
Member Author

azat commented Dec 27, 2022

Integration tests (asan) [6/6] — fail: 32, passed: 215, flaky: 1

Integration tests (tsan) [4/6] — fail: 1, passed: 350, flaky: 0

@nickitat
Copy link
Copy Markdown
Member

nickitat commented Jan 2, 2023

Stateless tests (debug) [2/5] - timeouts for unknown reason

@nickitat nickitat merged commit b9125bb into ClickHouse:master Jan 2, 2023
@azat azat deleted the groupArrayLast branch January 2, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickitat nickitat Awaiting requested review from nickitat

Assignees

@nickitat nickitat

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@azat @nickitat @robot-ch-test-poll3